From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>, "Koul, Vinod" <vinod.koul@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"tiwai@suse.de" <tiwai@suse.de>,
"Lin, Mengdong" <mengdong.lin@intel.com>,
"liam.r.girdwood@linux.intel.com"
<liam.r.girdwood@linux.intel.com>,
"Kp, Jeeja" <jeeja.kp@intel.com>,
"Prusty, Subhransu S" <subhransu.s.prusty@intel.com>,
"Patel, Vedang" <vedang.patel@intel.com>
Subject: Re: [PATCH v2 4/8] ASoC: topology: ABI - Add name element to snd_soc_tplg_stream
Date: Tue, 06 Oct 2015 18:35:28 +0200 [thread overview]
Message-ID: <5613F850.1040605@metafoo.de> (raw)
In-Reply-To: <20151006162520.GB30592@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 1130 bytes --]
On 10/06/2015 06:25 PM, Mark Brown wrote:
> On Tue, Oct 06, 2015 at 03:16:30PM +0000, Koul, Vinod wrote:
>> On Tue, 2015-10-06 at 11:34 +0100, Mark Brown wrote:
>
>>> No, I mean that if someone changes a name it'll invalidate topology
>>> files that reference that name.
>
>> Shouldn't this sort be checked in the alsa-lib while building the topology. It should
>> validate the names, graph and complete only when stuff is right.
>
> The problem isn't detecting the error, the point is that if someone
> upgrades their kernel and someone changed the DAI link name then their
> existing userspace will break. We don't want that error to be there to
> be detected in the first place.
Another thing to consider is that the topology firmware might be developed
against a non-upstream driver. And in order for the driver to go upstream it
needs changes that breaks the ABI interface to the firmware which is already
shipped and the vendor might not provide support for updating the firmware
file. Having these kind of tightly coupled interdependencies between driver
and firmware is quite risky business.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-10-06 17:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 9:28 [PATCH v2 0/8] ASoC: topology: ABI - Add support for PCM, BE & CC link mengdong.lin
2015-09-30 9:28 ` [PATCH v2 1/8] ASoC: topology: ABI - Add PCM Support and bump ABI version to 4 mengdong.lin
2015-09-30 9:29 ` [PATCH v2 2/8] ASoC: topology: ABI - Remove unused struct snd_soc_tplg_stream_config mengdong.lin
2015-09-30 9:30 ` [PATCH v2 3/8] ASoC: topology: ABI - Use __le32 instead of __u32 in snd_soc_tplg_dapm_widget mengdong.lin
2015-09-30 9:31 ` [PATCH v2 4/8] ASoC: topology: ABI - Add name element to snd_soc_tplg_stream mengdong.lin
2015-10-02 16:59 ` Mark Brown
2015-10-02 18:04 ` Liam Girdwood
2015-10-06 8:55 ` Lin, Mengdong
2015-10-06 10:34 ` Mark Brown
2015-10-06 15:16 ` Koul, Vinod
2015-10-06 16:25 ` Mark Brown
2015-10-06 16:35 ` Lars-Peter Clausen [this message]
2015-10-06 17:36 ` Mark Brown
2015-10-07 9:48 ` Lin, Mengdong
2015-10-07 10:04 ` Takashi Iwai
2015-10-07 10:23 ` Mark Brown
2015-10-07 10:08 ` Mark Brown
2015-10-06 15:06 ` Lin, Mengdong
2015-09-30 9:31 ` [PATCH v2 5/8] ASoC: topology: ABI - Change stream formats to a bitwise flag mengdong.lin
2015-09-30 9:32 ` [PATCH v2 6/8] ASoC: topology: ABI - Add the type for BE DAI link mengdong.lin
2015-09-30 9:32 ` [PATCH v2 7/8] ASoC: topology: ABI - Add configuration for BE & Codec-Codec DAI Links mengdong.lin
2015-09-30 9:32 ` [PATCH v2 8/8] ASoC: topology: ABI - Remove tdm_slot & dai_fmt from snd_soc_tplg_stream mengdong.lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5613F850.1040605@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mengdong.lin@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
--cc=vedang.patel@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).