Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Ricard Wanderlof <ricard.wanderlof@axis.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
	Ricard at home <ricard2005@butoba.net>
Subject: Re: [PATCH] ALSA: USB-audio: Add support for Novation	Nocturn MIDIcontrol surface
Date: Fri, 16 Oct 2015 18:25:58 +0200	[thread overview]
Message-ID: <56212516.2050003@ladisch.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1510161332480.4075@lnxricardw1.se.axis.com>

Ricard Wanderlof wrote:
> I've noticed that checkpatch complains about the space between the & and (,
> but in the interest of consistency I've not changed this. Is there some
> reason for the space

Yes.   But it's not a particularly substantial reason, and you're not
the first person to mention this checkpatch complaint, so feel free to
kill them.

> would it be worth while cleaning up the file?

Yes, it would be worth while cleaning up the file by restoring the
proper VID/PID order of the entries.  :)


Regards,
Clemens

  parent reply	other threads:[~2015-10-16 16:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 11:38 [PATCH] ALSA: USB-audio: Add support for Novation Nocturn MIDIcontrol surface Ricard Wanderlof
2015-10-16 12:31 ` Takashi Iwai
2015-10-16 16:25 ` Clemens Ladisch [this message]
2015-10-18  6:30   ` Ricard Wanderlof
2015-10-18  7:14     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56212516.2050003@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=ricard.wanderlof@axis.com \
    --cc=ricard2005@butoba.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox