Re: [PATCH 11/18] ASoC: n810: Use snd_pcm_hw_constraint_single()

[Jarkko Nikula <jarkko.nikula@bitmer.com>]

On 10/18/2015 04:39 PM, Lars-Peter Clausen wrote:
> Use the new snd_pcm_hw_constraint_single() helper function instead of
> calling snd_pcm_hw_constraint_minmax() with the same value for min and max
> to install a constraint that limits the possible configuration values to a
> single value. Using snd_pcm_hw_constraint_single() makes the indented
> result clearer and is slightly shorter.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
>  sound/soc/omap/n810.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/omap/n810.c b/sound/soc/omap/n810.c
> index dcb5336..190f868 100644
> --- a/sound/soc/omap/n810.c
> +++ b/sound/soc/omap/n810.c
> @@ -99,8 +99,7 @@ static int n810_startup(struct snd_pcm_substream *substream)
>  	struct snd_pcm_runtime *runtime = substream->runtime;
>  	struct snd_soc_pcm_runtime *rtd = substream->private_data;
>  
> -	snd_pcm_hw_constraint_minmax(runtime,
> -				     SNDRV_PCM_HW_PARAM_CHANNELS, 2, 2);
> +	snd_pcm_hw_constraint_single(runtime, SNDRV_PCM_HW_PARAM_CHANNELS, 2);
>  
>  	n810_ext_control(&rtd->card->dapm);
>  	return clk_prepare_enable(sys_clkout2);
> 
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>