Re: [PATCH 4/4] ASoC: sti: reset iec60958 settings on close

[Moise Gergaud <moise.gergaud@st.com>]

Hello,
To be compliant with SPDIF & HDMI-1.4 by using aplay, driver needs to 
set the channel status sampling freq = runtime rate; because channel 
status sampling freq is not set by aplay.
For HBRA, the application set the channel status sampling freq (that is 
different than the runtime rate).
=> by taking into account the 2 above cases, for each pcm session, 
driver shall be able to detect if the channel status sampling freq has 
already been set and set it if needed.

And also for robustness purpose: in case the channel status sampling 
freq is not set by the application, I think the driver shall set it.

Maybe I can limit my patch by resetting only the channel status sampling 
freq on close (actual patch reset all the fields of the channel status).

regards
Moïse


On 11/19/2015 06:50 PM, Mark Brown wrote:
> On Thu, Nov 19, 2015 at 02:54:10PM +0100, Moise Gergaud wrote:
>> Reset IEC 60958 settings for next PCM session.
>>
>> Signed-off-by: Moise Gergaud <moise.gergaud@st.com>
>> Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
>
> It's not 100% clear that we want to do this - normally controls are
> persistent and don't reset themselves per session.  Is this something we
> normally do for such controls?
>