From: Lars-Peter Clausen <lars@metafoo.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org,
Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH 3/3] ASoC: core: Change power state before rechecking endpoint
Date: Mon, 23 Nov 2015 19:13:12 +0100 [thread overview]
Message-ID: <56535738.1000802@metafoo.de> (raw)
In-Reply-To: <20151123172825.GU25173@localhost>
On 11/23/2015 06:28 PM, Vinod Koul wrote:
> On Mon, Nov 23, 2015 at 05:06:41PM +0100, Lars-Peter Clausen wrote:
>> On 11/23/2015 04:52 PM, Vinod Koul wrote:
>>> From: Jeeja KP <jeeja.kp@intel.com>
>>>
>>> For DAPM resume, we should first change the power state of the
>>> card and then recheck the endpoints. This ensures the dapm is
>>> resumed first and then userspace can resume the streams.
>>
>> The problem is that DAPM uses the userspace state to decide whether to power
>> up or not. So this change won't work, it will keep the endpoints suspended.
>
> Well our observation are bit different...
>
> When testing with aplay and suspending the system the DAPM was suspending
> fine and then alsa suspends PCMs, but on resume the DAPM is resumed last and
> the PCMs first, due to which the devices start underun!
> The DAPM should be resumed first and then we should allow userspace access
> (PCM resume from aplay)
>
> The change of order here helps in that
Sorry, overlooked something. We go to D2 earlier on and DAPM only is
suspended when the state is D3 and not only when it is not in D0.
Patch looks good.
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
next prev parent reply other threads:[~2015-11-23 18:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 15:52 [PATCH 0/3] ASoC: core: dapm more updates Vinod Koul
2015-11-23 15:52 ` [PATCH 1/3] ASoC: core: mark SND_SOC_BYTES_EXT as deprecated Vinod Koul
2015-11-25 12:59 ` Applied "ASoC: core: mark SND_SOC_BYTES_EXT as deprecated" to the asoc tree Mark Brown
2015-11-23 15:52 ` [PATCH 2/3] ASoC: core: add a dapm sink widget Vinod Koul
2015-11-24 9:48 ` Lars-Peter Clausen
2015-11-24 10:19 ` Vinod Koul
2015-11-25 12:51 ` Mark Brown
2015-11-25 12:59 ` Applied "ASoC: dapm: add a dapm sink widget" to the asoc tree Mark Brown
2015-11-23 15:52 ` [PATCH 3/3] ASoC: core: Change power state before rechecking endpoint Vinod Koul
2015-11-23 16:06 ` Lars-Peter Clausen
2015-11-23 17:28 ` Vinod Koul
2015-11-23 18:13 ` Lars-Peter Clausen [this message]
2015-11-24 10:17 ` Vinod Koul
2015-11-25 13:00 ` Applied "ASoC: core: Change power state before rechecking endpoint" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56535738.1000802@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).