From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, ffado-devel@lists.sf.net
Subject: Re: [PATCH 2/3] fireface: add transaction support
Date: Tue, 8 Dec 2015 12:29:07 +0100 [thread overview]
Message-ID: <5666BF03.7060102@ladisch.de> (raw)
In-Reply-To: <5666BE1A.80304@sakamocchi.jp>
Takashi Sakamoto wrote:
> On Dec 08 2015 19:22, Clemens Ladisch wrote:
>> Takashi Sakamoto wrote:
>>> + /* Calculate consume bytes. */
>>> + consume = calculate_message_bytes(status);
>>> + if (consume <= 0)
>>> + return;
>>
>> As far as I can see, sending one of the "undefined" bytes can stop the
>> stream permanently. Invalid bytes need to be acked to ignore/remove
>> them.
>
> Exactly. We should find better way to handle such messages. Do you have
> any good ideas?
Call snd_rawmidi_transmit_ack(, 1) and continue.
Regards,
Clemens
next prev parent reply other threads:[~2015-12-08 11:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 13:23 [RFC][PATCH 0/3] ALSA: fireface: new driver for RME Fireface series (MIDI only) Takashi Sakamoto
2015-12-06 13:23 ` [PATCH 1/3] fireface: add skeleton for RME Fireface series Takashi Sakamoto
2015-12-06 22:13 ` [FFADO-devel] " Jonathan Woithe
2015-12-07 1:32 ` Takashi Sakamoto
2015-12-07 2:05 ` Jonathan Woithe
2015-12-06 13:23 ` [PATCH 2/3] fireface: add transaction support Takashi Sakamoto
2015-12-08 10:22 ` Clemens Ladisch
2015-12-08 11:25 ` Takashi Sakamoto
2015-12-08 11:29 ` Clemens Ladisch [this message]
2015-12-08 12:20 ` Takashi Sakamoto
2015-12-08 12:36 ` Clemens Ladisch
2015-12-10 11:31 ` Takashi Sakamoto
2015-12-06 13:23 ` [PATCH 3/3] fireface: add support for MIDI functionality Takashi Sakamoto
2015-12-06 14:29 ` [FFADO-devel] [RFC][PATCH 0/3] ALSA: fireface: new driver for RME Fireface series (MIDI only) Илья
2015-12-06 21:57 ` Jonathan Woithe
2015-12-07 1:27 ` Takashi Sakamoto
2015-12-07 1:37 ` Jonathan Woithe
2015-12-07 1:52 ` Takashi Sakamoto
2015-12-07 2:05 ` Takashi Sakamoto
2015-12-07 2:21 ` Jonathan Woithe
2015-12-07 2:42 ` Takashi Sakamoto
2015-12-07 3:01 ` Jonathan Woithe
2015-12-07 7:37 ` Clemens Ladisch
2015-12-07 8:41 ` Jonathan Woithe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5666BF03.7060102@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=ffado-devel@lists.sf.net \
--cc=o-takashi@sakamocchi.jp \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).