From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>, tiwai@suse.de
Cc: alsa-devel@alsa-project.org, ffado-devel@lists.sf.net
Subject: Re: [PATCH 02/10] ALSA: dice: wait for ensuring phase lock
Date: Sat, 12 Dec 2015 12:42:18 +0100 [thread overview]
Message-ID: <566C081A.1000804@ladisch.de> (raw)
In-Reply-To: <1449889570-26641-3-git-send-email-o-takashi@sakamocchi.jp>
Takashi Sakamoto wrote:
> Some users have reported that their Dice based models generate packet
> discontinuity at the beginning of streaming. When standing on an
> assumption that the value of SYT field in transferred AMDTP packet comes
> from phase lock circuit, this comes from phase unlocking with current
> clock source. Just waiting for dice notification is not enough to prevent
> from packet discontinuity.
>
> This commit checks the register of phase lock after clock state change for
> this purpose.
Is this patch actually known to help?
This discontinuity could also come from an unexpected initial DBC value.
I think it would be a good idea to unconditionally enable
CIP_SKIP_INIT_DBC_CHECK for all devices.
Regards,
Clemens
next prev parent reply other threads:[~2015-12-12 11:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 3:06 [RFC][PATCH 00/10 v2] ALSA: dice: stabiliza packet streaming Takashi Sakamoto
2015-12-12 3:06 ` [PATCH 01/10] ALSA: dice: expand timeout to wait for Dice notification Takashi Sakamoto
2015-12-12 3:06 ` [PATCH 02/10] ALSA: dice: wait for ensuring phase lock Takashi Sakamoto
2015-12-12 11:42 ` Clemens Ladisch [this message]
2015-12-15 16:00 ` Takashi Sakamoto
2015-12-12 3:06 ` [PATCH 03/10] ALSA: dice: split subaddress check from category check Takashi Sakamoto
2015-12-12 3:06 ` [PATCH 04/10] ALSA: dice: postpone probe processing Takashi Sakamoto
2015-12-12 3:06 ` [PATCH 05/10] ALSA: dice: limit to current sampling transfer frequency Takashi Sakamoto
2015-12-12 3:06 ` [PATCH 06/10] ALSA: dice: limit stream " Takashi Sakamoto
2015-12-12 3:06 ` [PATCH 07/10] ALSA: dice: add MIDI ports according to current number of MIDI substreams Takashi Sakamoto
2015-12-12 3:06 ` [PATCH 08/10] ALSA: dice: get the number of MBLA data channel at opening PCM substream Takashi Sakamoto
2015-12-12 3:06 ` [PATCH 09/10] ALSA: dice: purge generating channel cache Takashi Sakamoto
2015-12-12 3:06 ` [PATCH 10/10] ALSA: dice: ensure phase lock before starting streaming Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566C081A.1000804@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=ffado-devel@lists.sf.net \
--cc=o-takashi@sakamocchi.jp \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox