From: Mengdong Lin <mengdong.lin@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
mengdong.lin@intel.com, liam.r.girdwood@linux.intel.com,
jeeja.kp@intel.com, subhransu.s.prusty@intel.com
Subject: Can we remove the rtd_aux for the aux_devs?
Date: Tue, 22 Dec 2015 16:15:26 +0800 [thread overview]
Message-ID: <5679069E.6070106@linux.intel.com> (raw)
In-Reply-To: <567121DC.5080601@linux.intel.com>
Revise the subject.
Could someone clarify if the rtd_aux in struct snd_soc_card is still needed?
We want to replace the aux_dev by aux_component.
If the rtd_aux is no longer needed, we can remove the array and it will
become easier to handle an aux_dev as a generic component.
Thanks
Mengdong
On 12/16/2015 04:33 PM, Mengdong Lin wrote:
>
>
> On 12/15/2015 07:23 PM, Mark Brown wrote:
>> On Tue, Dec 15, 2015 at 04:06:14PM +0800, Mengdong Lin wrote:
>>
>>> I still have some basic questions:
>>
>>> 1. What are the typical usages for aux_dev?
>>> For CODEC<->CODEC link or external headset detection chip?
>>
>> Neither, it's for analogue devices.
>
> Got it. Thanks!
>
>>
>>> 2. Why we need the rtd array 'rtd_aux' for the aux_devs?
>>> If the codec has DAIs and used by a DAI link, the ASoC will
>>> create a rtd
>>> for the link.
>>
>> There are (or were at the time) assumptions in drivers that there will
>> be a rtd there so it was easier to provide a stub.
>>
>
> Can we remove this rtd array if current driver does not need the stub?
>
> For the replacement of aux_dev by aux_component, can we define like below?
>
> struct snd_soc_aux_component {
> const char *comp_name; ... no longer assume they're only codecs
> const char *comp_of_node;
>
> /* machine specific init */
> int (*init)(struct snd_soc_component *componnent);
> };
>
> The ASoC can use the comp_name or comp_of_node to find the components
> and probe them.
>
> Thanks
> Mengdong
>
next prev parent reply other threads:[~2015-12-22 7:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 6:08 [PATCH 0/5] ASoC: Allow topology to create DAI links mengdong.lin
2015-12-02 6:11 ` [PATCH 1/5] ASoC: Implement DAI links in a list & define API to add/remove a link mengdong.lin
2015-12-08 18:03 ` Mark Brown
2015-12-08 19:11 ` Applied "ASoC: Implement DAI links in a list & define API to add/remove a link" to the asoc tree Mark Brown
2015-12-02 6:11 ` [PATCH 2/5] ASoC: Define add/remove_dai_link ops for a soc card mengdong.lin
2015-12-08 19:11 ` Applied "ASoC: Define add/remove_dai_link ops for a soc card" to the asoc tree Mark Brown
2015-12-02 6:11 ` [PATCH 3/5] ASoC: soc_bind_dai_link() directly returns success for a bound DAI link mengdong.lin
2015-12-02 6:11 ` [PATCH 4/5] ASoC: Bind new DAI links after probing components mengdong.lin
2015-12-02 6:11 ` [PATCH 5/5] ASoC: The soc card can have auxiliary components mengdong.lin
2015-12-08 18:58 ` Mark Brown
2015-12-09 9:09 ` Mengdong Lin
2015-12-09 20:38 ` Mark Brown
2015-12-10 10:05 ` Mengdong Lin
2015-12-11 20:22 ` Mark Brown
2015-12-15 8:06 ` Mengdong Lin
2015-12-15 11:23 ` Mark Brown
2015-12-16 8:33 ` Mengdong Lin
2015-12-18 9:35 ` Mark Brown
2015-12-22 8:15 ` Mengdong Lin [this message]
2015-12-22 23:56 ` Can we remove the rtd_aux for the aux_devs? Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5679069E.6070106@linux.intel.com \
--to=mengdong.lin@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mengdong.lin@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).