Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Petr Kulhavy <petr@barix.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Subject: Re: DT soundcard driver with special clock routing
Date: Wed, 23 Dec 2015 13:43:01 +0100	[thread overview]
Message-ID: <567A96D5.5080803@samsung.com> (raw)
In-Reply-To: <567118AB.5060302@barix.com>

(Adding ASoC maintainer at Cc).

On 16/12/15 08:54, Petr Kulhavy wrote:
> Currently I'm struggling with the clocks on the DaVinci platform as the 
> clock tree is defined in the platform driver and not in DT.
> Is there a way to reference the clocks by names from DT, or does the 
> DaVinci clock driver need to be rewritten for DT support?

I don't think so, you need a clock provider to reference clocks in DT.
You may want to ask such question on linux-arm-kernel@lists.infradead.org
mailing list and Cc relevant maintainer(s).

> There is one more thing I came across using the simple soundcard driver. 
> The codec needs to be set to generate the clock via PLL.
> Unfortunately the simple soundcard always passes clock ID 0 to 
> snd_soc_dai_set_sysclk() - I need a different value for the internal PLL.
>
> What is the preferred approach here? On one hand the simple soundcard 
> driver could be extended with a DT parameter "clock ID".
> Or does a dedicated soundcard driver need to be written?

I'm not sure what is the preference here, I guess a dedicated soundcard
driver could be a way to go in your case.

> On 14.12.2015 13:28, Sylwester Nawrocki wrote:
>> Yes, you need the clock provider somewhere. In my case it was the I2S 
>> driver that registered a clock provider. Probably you can add your 
>> output clock provider to your SoC's main clock controller driver, and 
>> perhaps use pinctrl API for the pin function mux setup. You can place 
>> assigned-clock* DT properties in the clock provider node and the PLL's 
>> will be configured by the kernel's clk subsystem. Grep for 
>> of_clk_set_defaults or see last chapter of 
>> Documentation/devicetree/bindings/clock/clock-bindings.txt. 

-- 
Regards,
Sylwester

      reply	other threads:[~2015-12-23 12:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 16:31 DT soundcard driver with special clock routing Petr Kulhavy
2015-12-10 17:13 ` Sylwester Nawrocki
2015-12-14 11:32   ` Petr Kulhavy
2015-12-14 12:28     ` Sylwester Nawrocki
2015-12-16  7:54       ` Petr Kulhavy
2015-12-23 12:43         ` Sylwester Nawrocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567A96D5.5080803@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=petr@barix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox