alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@tabi.org>
To: Mark Brown <broonie@kernel.org>,
	"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Fabio Estevam <festevam@gmail.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	Xiubo Li <Xiubo.Lee@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults
Date: Mon, 11 Jan 2016 09:45:37 -0600	[thread overview]
Message-ID: <5693CE21.8010009@tabi.org> (raw)
In-Reply-To: <20160111145430.GE6588@sirena.org.uk>

Mark Brown wrote:
> That's possibly problematic because the flat cache will of necessity end
> up with defaults (of 0 from the kzalloc()) for all the registers.
> You'll still have default values in the cache, though some of the
> behaviour around optimising syncs does change without them explicitly
> given.  It does deal with the allocation issue but given that the issue
> was incorrect defaults I'd be a bit concerned.

Ok, I'm confused.  Granted, all of this regcache stuff was added after I 
stopped working on this driver, so I'm out of the loop.  But it appears 
that the regcache cannot properly handle an uninitialized cache.  I 
would expect it to know to perform hard reads of any registers that are 
uninitialized.

If the regcache wants to have an initialized cache, then it should 
automatically perform reads an all non-volatile, non-precious registers 
at initialization.

  reply	other threads:[~2016-01-11 15:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-20 20:33 [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Maciej S. Szmigiero
2015-12-23 13:13 ` Fabio Estevam
2016-01-10 12:22 ` Applied "ASoC: fsl_ssi: remove register defaults" to the asoc tree Mark Brown
2016-01-10 21:36 ` [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Timur Tabi
2016-01-11 12:04 ` Fabio Estevam
2016-01-11 12:10   ` Fabio Estevam
2016-01-11 13:57     ` Maciej S. Szmigiero
2016-01-11 14:05       ` Fabio Estevam
2016-01-16 23:56         ` Maciej S. Szmigiero
2016-01-17  0:10           ` Timur Tabi
2016-01-17  1:01             ` Maciej S. Szmigiero
2016-01-17  5:16               ` Timur Tabi
2016-01-17 14:16                 ` Maciej S. Szmigiero
2016-01-17 14:39                   ` Maciej S. Szmigiero
2016-01-17 18:38                     ` Timur Tabi
2016-01-17 22:02                       ` Maciej S. Szmigiero
2016-01-18 12:51                         ` Fabio Estevam
2016-01-18 19:08                           ` Maciej S. Szmigiero
2016-01-27 18:37                         ` Applied "ASoC: fsl_ssi: remove explicit register defaults" to the asoc tree Mark Brown
2016-02-22  3:14                         ` Mark Brown
2016-01-11 14:00     ` [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Mark Brown
2016-01-11 14:10       ` Maciej S. Szmigiero
2016-01-11 14:54         ` Mark Brown
2016-01-11 15:45           ` Timur Tabi [this message]
2016-01-11 16:12             ` Mark Brown
2016-01-12  1:23               ` Timur Tabi
2016-01-12  1:34                 ` Mark Brown
2016-01-12  1:53                   ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5693CE21.8010009@tabi.org \
    --to=timur@tabi.org \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=festevam@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mail@maciej.szmigiero.name \
    --cc=nicoleotsuka@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).