From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Date: Mon, 11 Jan 2016 19:23:54 -0600 Message-ID: <569455AA.4060907@tabi.org> References: <5677107C.60904@maciej.szmigiero.name> <20160111140038.GC6588@sirena.org.uk> <5693B7CC.8000905@maciej.szmigiero.name> <20160111145430.GE6588@sirena.org.uk> <5693CE21.8010009@tabi.org> <20160111161225.GJ6588@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160111161225.GJ6588@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: "Maciej S. Szmigiero" , Fabio Estevam , "alsa-devel@alsa-project.org" , Nicolin Chen , Xiubo Li , Liam Girdwood , "linuxppc-dev@lists.ozlabs.org" , linux-kernel List-Id: alsa-devel@alsa-project.org Mark Brown wrote: > regcache handles this fine, it's perfectly happy to just go and allocate > the cache as registers get used (this is why the code that's doing the > allocation exists...). What is causing problems here is that the first > access to the register is happening in interrupt context so we can't do > a GFP_KERNEL allocation for it. Considering how small and not-sparse the SSI register space is, would using REGCACHE_FLAT be appropriate?