From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Date: Sat, 16 Jan 2016 23:16:24 -0600 Message-ID: <569B23A8.3010006@tabi.org> References: <5677107C.60904@maciej.szmigiero.name> <5693B4C1.4060400@maciej.szmigiero.name> <569AD8A7.7080803@maciej.szmigiero.name> <569ADC0D.2000807@tabi.org> <569AE7D1.6050607@maciej.szmigiero.name> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from muin.pair.com (muin.pair.com [209.68.1.55]) by alsa0.perex.cz (Postfix) with ESMTP id 939DD2604E2 for ; Sun, 17 Jan 2016 06:16:07 +0100 (CET) In-Reply-To: <569AE7D1.6050607@maciej.szmigiero.name> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Maciej S. Szmigiero" Cc: "alsa-devel@alsa-project.org" , Xiubo Li , "linuxppc-dev@lists.ozlabs.org" , Liam Girdwood , linux-kernel , Nicolin Chen , Mark Brown , Fabio Estevam List-Id: alsa-devel@alsa-project.org Maciej S. Szmigiero wrote: > This is because (at least according to the datasheet) imx21-class SSI > registers end at CCSR_SSI_SRMSK (no SACC{ST,EN,DIS} regs), so > reading them for cache initialization may not be safe. > > Also, a "MXC 91221 only" comment before these regs in FSL tree > (drivers/mxc/ssi/registers.h) seems to confirm that these registers > aren't present at least on some SSI (or SoC) models. Can't we just mark them as precious or something, so that we don't have to have two structures?