From: Timur Tabi <timur@tabi.org>
To: Arnaud Mouiche <arnaud.mouiche@invoxia.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, Caleb Crome <caleb@crome.org>
Subject: Re: [PATCH v3 1/6] ASoC: fsl_ssi: Real hardware channels max number is 32
Date: Mon, 18 Jan 2016 09:46:07 -0600 [thread overview]
Message-ID: <569D08BF.7000008@tabi.org> (raw)
In-Reply-To: <1453130771-24419-2-git-send-email-arnaud.mouiche@invoxia.com>
Arnaud Mouiche wrote:
> The max number of slots in TDM mode is 32:
> - Frame Rate Divider Control is a 5bit value
> - Time slot mask registers control 32 slots.
>
> Signed-off-by: Arnaud Mouiche<arnaud.mouiche@invoxia.com>
> ---
> sound/soc/fsl/fsl_ssi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> index 40dfd8a..cfc78b8 100644
> --- a/sound/soc/fsl/fsl_ssi.c
> +++ b/sound/soc/fsl/fsl_ssi.c
> @@ -1167,14 +1167,14 @@ static struct snd_soc_dai_driver fsl_ssi_dai_template = {
> .playback = {
> .stream_name = "CPU-Playback",
> .channels_min = 1,
> - .channels_max = 2,
> + .channels_max = 32,
TDM mode is not normally used. What happens if we're not in TDM mode,
and the user tries to start a stream with more than 2 channels?
next prev parent reply other threads:[~2016-01-18 15:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 15:26 [PATCH v3 0/6] ASoC: fsl_ssi: Fixing various channel slips and bad samples insertions Arnaud Mouiche
2016-01-18 15:26 ` [PATCH v3 1/6] ASoC: fsl_ssi: Real hardware channels max number is 32 Arnaud Mouiche
2016-01-18 15:46 ` Timur Tabi [this message]
2016-01-18 15:56 ` arnaud.mouiche
2016-04-25 17:20 ` Caleb Crome
2016-01-18 15:26 ` [PATCH v3 2/6] ASoC: fsl_ssi: The IPG/5 limitation concerns the bitclk, not the sysclk Arnaud Mouiche
2016-04-25 17:21 ` Caleb Crome
2016-01-18 15:26 ` [PATCH v3 3/6] ASoC: fsl_ssi: Save a dev reference for dev_err() purpose Arnaud Mouiche
2016-04-25 17:21 ` Caleb Crome
2016-01-18 15:26 ` [PATCH v3 4/6] ASoC: fsl_ssi: Fix samples being dropped as Playback startup Arnaud Mouiche
2016-04-25 17:22 ` Caleb Crome
2016-01-18 15:26 ` [PATCH v3 5/6] ASoC: fsl_ssi: Fix channel slipping in Playback at startup Arnaud Mouiche
2016-04-25 17:22 ` Caleb Crome
2016-01-18 15:26 ` [PATCH v3 6/6] ASoC: fsl_ssi: Fix channel slipping on capture (or playback) restart in full duplex Arnaud Mouiche
2016-04-25 17:22 ` Caleb Crome
2016-04-29 3:44 ` [PATCH v3 0/6] ASoC: fsl_ssi: Fixing various channel slips and bad samples insertions Fabio Estevam
2016-04-29 3:54 ` Nicolin Chen
2016-04-29 16:49 ` Caleb Crome
2016-05-02 22:29 ` arnaud.mouiche
2016-05-02 22:32 ` Fabio Estevam
2016-05-02 22:35 ` arnaud.mouiche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569D08BF.7000008@tabi.org \
--to=timur@tabi.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.mouiche@invoxia.com \
--cc=broonie@kernel.org \
--cc=caleb@crome.org \
--cc=lgirdwood@gmail.com \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).