Re: [PATCH 18/19] ASoC: Intel: Atom: add support for RT5642

Re: [PATCH 18/19] ASoC: Intel: Atom: add support for RT5642

[Luka Karinja]

> The machine driver is not loaded when the BIOS uses the 10EC5642
> _HID. Add it to the white list of known _HIDs, codec_name is
> already taken care of by previous commit
>
> Tested on Asus T100TAF.
>

I'm trying to get sound working on my T100TAF i did apply all the 19 patches
on top of broonie/sound and added UCM files to my system.
Does the TAF need different UCM file than the T100TA?

aplay -l
**** List of PLAYBACK Hardware Devices ****
card 0: bytcrrt5640 [bytcr-rt5640], device 0: Baytrail Audio (*) []
   Subdevices: 1/1
   Subdevice #0: subdevice #0
card 0: bytcrrt5640 [bytcr-rt5640], device 1: Deep-Buffer Audio (*) []
   Subdevices: 1/1
   Subdevice #0: subdevice #0

dmesg:

[    5.209239] Adding 1049596k swap on /dev/mmcblk0p4.  Priority:-1 
extents:1 across:1049596k SSFS
[    5.219099] input: PC Speaker as /devices/platform/pcspkr/input/input6
[    5.273802] i2c i2c-10: Added multiplexed i2c bus 13
[    5.274629] intel_sst_acpi 80860F28:00: LPE base: 0x50a00000 
size:0x200000
[    5.274638] intel_sst_acpi 80860F28:00: IRAM base: 0x50ac0000
[    5.274671] intel_sst_acpi 80860F28:00: DRAM base: 0x50b00000
[    5.274685] intel_sst_acpi 80860F28:00: SHIM base: 0x50b40000
[    5.274700] intel_sst_acpi 80860F28:00: Mailbox base: 0x50b44000
[    5.274712] intel_sst_acpi 80860F28:00: DDR base: 0x20000000
[    5.274842] intel_sst_acpi 80860F28:00: Got drv data max stream 25
[    5.290156] Error: Driver 'pcspkr' is already registered, aborting...
[    5.311924] random: nonblocking pool is initialized
[    5.397912] EXT4-fs (mmcblk0p2): mounted filesystem with ordered data 
mode. Opts: data=ordered
[    5.506882] genirq: Flags mismatch irq 8. 00000083 (volume_down) vs. 
00000000 (rtc0)
[    5.507025] gpio-keys gpio-keys.0.auto: Unable to claim irq 8; error -16
[    5.507283] gpio-keys: probe of gpio-keys.0.auto failed with error -16
[    5.507518] input: gpio-keys as 
/devices/platform/gpio-keys.1.auto/input/input8
[    5.519513] iTCO_vendor_support: vendor-support=0
[    5.591021] iTCO_wdt: Intel TCO WatchDog Timer Driver v1.11
[    5.591153] iTCO_wdt: Found a Bay Trail SoC TCO device (Version=3, 
TCOBASE=0x0460)
[    5.604447] iTCO_wdt: initialized. heartbeat=30 sec (nowayout=0)
[    5.613586] bytcr_rt5640 bytcr_rt5640: snd-soc-dummy-dai <-> 
media-cpu-dai mapping ok
[    5.613794] bytcr_rt5640 bytcr_rt5640: snd-soc-dummy-dai <-> 
deepbuffer-cpu-dai mapping ok
[    5.613922] compress asoc: snd-soc-dummy-dai <-> compress-cpu-dai 
mapping ok
[    5.615555] bytcr_rt5640 bytcr_rt5640: rt5640-aif1 <-> ssp2-port 
mapping ok
[    5.642183] asus_wmi: ASUS WMI generic driver loaded
[    5.663786] usbcore: registered new interface driver usbmouse
[    5.665362] usbcore: registered new interface driver usbkbd
[    5.681990] asus_wmi: Initialization: 0x1
[    5.682121] asus_wmi: BIOS WMI version: 7.9
[    5.682219] asus_wmi: SFUN value: 0x37
[    5.685337] input: Asus WMI hotkeys as 
/devices/platform/asus-nb-wmi/input/input9
[    5.708007] asus_wmi: Number of fans: 1
[    5.801413] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_out tx interleaver slot 0 doesn't have DAPM widget!!!
[    5.801529] input: SIS0817:00 0457:1071 as 
/devices/platform/80860F41:03/i2c-11/i2c-SIS0817:00/0018:0457:1071.0004/input/input10
[    5.802167] hid-multitouch 0018:0457:1071.0004: input,hidraw3: I2C 
HID v1.00 Device [SIS0817:00 0457:1071] on i2c-SIS0817:00
[    5.816775] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_out tx interleaver slot 1 doesn't have DAPM widget!!!
[    5.816996] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_out tx interleaver slot 2 doesn't have DAPM widget!!!
[    5.817204] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_out tx interleaver slot 3 doesn't have DAPM widget!!!
[    5.817405] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_in rx deinterleaver codec_in0_0 doesn't have DAPM widget!!!
[    5.817616] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_in rx deinterleaver codec_in0_1 doesn't have DAPM widget!!!
[    5.818884] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_in rx deinterleaver codec_in1_0 doesn't have DAPM widget!!!
[    5.819109] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_in rx deinterleaver codec_in1_1 doesn't have DAPM widget!!!
[    5.911351] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_out tx interleaver slot 0 doesn't have DAPM widget!!!
[    5.911578] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_out tx interleaver slot 1 doesn't have DAPM widget!!!
[    5.911787] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_out tx interleaver slot 2 doesn't have DAPM widget!!!
[    5.911997] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_out tx interleaver slot 3 doesn't have DAPM widget!!!
[    5.912201] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_in rx deinterleaver codec_in0_0 doesn't have DAPM widget!!!
[    5.912417] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_in rx deinterleaver codec_in0_1 doesn't have DAPM widget!!!
[    5.912634] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_in rx deinterleaver codec_in1_0 doesn't have DAPM widget!!!
[    5.915142] sst-mfld-platform sst-mfld-platform: Slot control: 
codec_in rx deinterleaver codec_in1_1 doesn't have DAPM widget!!!
[    6.042680] intel_rapl: Found RAPL domain package
[    6.042692] intel_rapl: Found RAPL domain core
[    6.247467] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[    6.247489] Bluetooth: BNEP filters: protocol multicast
[    6.247515] Bluetooth: BNEP socket layer initialized
[    7.524852] brcmf_sdio_drivestrengthinit: No SDIO Drive strength init 
done for chip 43340 rev 2 pmurev 20
[    7.525341] usbcore: registered new interface driver brcmfmac
[    7.722004] brcmf_c_preinit_dcmds: Firmware version = wl0: Jun 17 
2014 11:48:43 version 6.10.190.49 (r485840) FWID 01-8744bcd2
[    7.739335] brcmf_cfg80211_reg_notifier: not a ISO3166 code
[    7.899345] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready
[    7.921532] audit: type=1006 audit(1450805770.516:2): pid=1018 uid=0 
old-auid=4294967295 auid=1000 old-ses=4294967295 ses=1 res=1
[    7.984230] audit: type=1006 audit(1450805770.580:3): pid=1091 uid=0 
old-auid=4294967295 auid=1000 old-ses=4294967295 ses=2 res=1
[    7.996410] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready
[    8.151283] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready
[    9.038571] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready
[   11.245916] Bluetooth: hci1: BCM: chip id 82
[   11.245928] Bluetooth: hci1: BCM43341B0 (002.001.014) build 0000
[   11.755123] Bluetooth: hci1: BCM (002.001.014) build 0164
[   14.513027] intel_sst_acpi 80860F28:00: Wait timed-out condition:0x0, 
msg_id:0x0 fw_state 0x1
[   14.513045] intel_sst_acpi 80860F28:00: fw download failed -16
[   14.513067] intel_sst_acpi 80860F28:00: FW download fail -16
[   14.513864]  Baytrail Audio Port: ASoC: no backend DAIs enabled for 
Baytrail Audio Port
[   14.514676]  Baytrail Audio Port: ASoC: no backend DAIs enabled for 
Baytrail Audio Port
[   14.515574]  Baytrail Audio Port: ASoC: no backend DAIs enabled for 
Baytrail Audio Port
[   14.518058]  Baytrail Audio Port: ASoC: no backend DAIs enabled for 
Baytrail Audio Port
[   14.518941]  Baytrail Audio Port: ASoC: no backend DAIs enabled for 
Baytrail Audio Port
[   14.520293]  Baytrail Audio Port: ASoC: no backend DAIs enabled for 
Baytrail Audio Port
[   14.525383]  Baytrail Audio Port: ASoC: no backend DAIs enabled for 
Baytrail Audio Port
[   14.527248]  Baytrail Audio Port: ASoC: no backend DAIs enabled for 
Baytrail Audio Port
[   14.528335]  Baytrail Audio Port: ASoC: no backend DAIs enabled for 
Baytrail Audio Port
[   14.534111]  Baytrail Audio Port: ASoC: no backend DAIs enabled for 
Baytrail Audio Port

Re: [PATCH 18/19] ASoC: Intel: Atom: add support for RT5642

[Pierre-Louis Bossart]

 >> The machine driver is not loaded when the BIOS uses the 10EC5642
>> _HID. Add it to the white list of known _HIDs, codec_name is
>> already taken care of by previous commit
>>
>> Tested on Asus T100TAF.
>>
>
> I'm trying to get sound working on my T100TAF i did apply all the 19
> patches
> on top of broonie/sound and added UCM files to my system.
> Does the TAF need different UCM file than the T100TA?


The probe was tested but I am still fighting to get audio out. There are 
additional patches needed to work-around a BIOS changes that fixes the 
download issue shown in your log and also a change in the I2S routing, 
but we can't figure out if there are any additional changes needed. I 
suspect something is wrong with the i2S pin configuration (gpio setup)
Those patches and updated firmware have not been submitted so far, i'd 
like to do so when it's actually working. This is on our to-do list, 
along with MCLK support and jack detection. There are so many variations 
of hardware that we are progressing slowly unfortunately.

Re: [PATCH 18/19] ASoC: Intel: Atom: add support for RT5642

[Luka Karinja]

> >> The machine driver is not loaded when the BIOS uses the 10EC5642
>>> _HID. Add it to the white list of known _HIDs, codec_name is
>>> already taken care of by previous commit
>>>
>>> Tested on Asus T100TAF.
>>>
>>
>> I'm trying to get sound working on my T100TAF i did apply all the 19
>> patches
>> on top of broonie/sound and added UCM files to my system.
>> Does the TAF need different UCM file than the T100TA?
>
>
> The probe was tested but I am still fighting to get audio out. There 
> are additional patches needed to work-around a BIOS changes that fixes 
> the download issue shown in your log and also a change in the I2S 
> routing, but we can't figure out if there are any additional changes 
> needed. I suspect something is wrong with the i2S pin configuration 
> (gpio setup)
> Those patches and updated firmware have not been submitted so far, i'd 
> like to do so when it's actually working. This is on our to-do list, 
> along with MCLK support and jack detection. There are so many 
> variations of hardware that we are progressing slowly unfortunately.
>
>
Ok, thanks for the clarification, been fighting audio on it for a year 
too. i'll keep checking the list for followups

Re: [PATCH 18/19] ASoC: Intel: Atom: add support for RT5642

[Luka Karinja]

Hello

> >> The machine driver is not loaded when the BIOS uses the 10EC5642
>>> _HID. Add it to the white list of known _HIDs, codec_name is
>>> already taken care of by previous commit
>>>
>>> Tested on Asus T100TAF.
>>>
>>
>> I'm trying to get sound working on my T100TAF i did apply all the 19
>> patches
>> on top of broonie/sound and added UCM files to my system.
>> Does the TAF need different UCM file than the T100TA?
>
>
> The probe was tested but I am still fighting to get audio out. There 
> are additional patches needed to work-around a BIOS changes that fixes 
> the download issue shown in your log and also a change in the I2S 
> routing, but we can't figure out if there are any additional changes 
> needed. I suspect something is wrong with the i2S pin configuration 
> (gpio setup)
> Those patches and updated firmware have not been submitted so far, i'd 
> like to do so when it's actually working. This is on our to-do list, 
> along with MCLK support and jack detection. There are so many 
> variations of hardware that we are progressing slowly unfortunately.
>
Are there any updates on the TAF sound? I have been following your 
github, and saw there is a new TAF branch.
Is it already possible to get sound out of our devices?

Thanks

Luka

Re: [PATCH 18/19] ASoC: Intel: Atom: add support for RT5642

[Pierre-Louis Bossart]

> Are there any updates on the TAF sound? I have been following your
> github, and saw there is a new TAF branch.
> Is it already possible to get sound out of our devices?

Nope, it's a debug branch. The DACs get powered when audio starts 
playing but there is no sound. It's by far the most puzzling problem 
we've seen, we haven't been able to pin-point where the issue is (I2S 
not working, controls, etc). we did get access to the schematics which 
did show some changes on speakers and mics (more quirks, yay) but it's 
not enough.

[PATCH 00/19] Baytrail/Cherrytrail cleanups and fixes

[Pierre-Louis Bossart]

Set of patches to provide better upstream support for BYT/CHT 
platforms (24 bit, Deep-buffer, DPCM). This was tested on Asus T100 and 
Minnowboard.
A set of UCM files is available at https://github.com/plbossart/UCM.git for 
better integration with Ubuntu/pulseaudio
(no need for asound.state or asound.conf)

Acknowledgements:
Keyon Jie for his MinnowBoard validation
Sebastien Guiriec for pointing out the switch logic issue and fixing SSP configs
Vinod Koul for providing codec/mixer configurations
Francisco Mendez for his help with the MCLK and jack detection
Jack Yu and Bard Liao for their codec support

Known issues: 
noise on startup when using speakers

Once this batch is merged, the following updates will be provided:
MCLK support to fix noise issues
BYT-CR fixes
jack detection

Jack Yu (1):
  ASoC: rt5640: add ASRC support

Jorge Fernandez Monteagudo (1):
  ASoC: Intel: Atom: Add support for HP ElitePad 1000 G2

Pierre-Louis Bossart (16):
  ASoC: Intel: fix ACPI probe regression with Atom DPCM driver
  ASoC: Intel: boards: align pin names between byt-rt5640 drivers
  ASoC: Intel: boards: start merging byt-rt5640 drivers
  ASoC: Intel: boards: merge DMI-based quirks in bytcr-rt5640 driver
  ASoC: Intel: tag byt-rt5640 machine driver as deprecated
  ASoc: Intel: Atom: add deep buffer definitions for atom platforms
  ASoC: Intel: boards: add DEEP_BUFFER support for BYT/CHT/BSW
  ASoC: Intel: Atom: add 24-bit support for media playback and capture
  ASoC: Intel: Atom: clean-up compressed DAI definition
  ASoC: Intel: Atom: flip logic for gain Switch
  ASoC: codec: rt5651: add ACPI and OF support
  ASoC: Intel: add bytct-rt5651 machine driver
  ASoC: intel: boards: add card for MinnowBoard I2S access
  ASoC: Intel: bytcr-rt5640: enable ASRC
  ASoC: Intel: bytcr_rt5640: fixup DAI codec_name with HID
  ASoC: Intel: Atom: add support for RT5642

Sebastien Guiriec (1):
  ASoC: Intel: bytcr_rt5640: set SSP to I2S mode 2ch

 arch/x86/include/asm/platform_sst_audio.h    |   1 +
 sound/soc/codecs/rt5640.c                    | 103 ++++++++
 sound/soc/codecs/rt5640.h                    |  17 ++
 sound/soc/codecs/rt5651.c                    |  19 ++
 sound/soc/intel/Kconfig                      |  35 ++-
 sound/soc/intel/atom/sst-atom-controls.c     |   5 +-
 sound/soc/intel/atom/sst-atom-controls.h     |   1 +
 sound/soc/intel/atom/sst-mfld-platform-pcm.c |  20 +-
 sound/soc/intel/atom/sst/sst_acpi.c          |  25 +-
 sound/soc/intel/boards/Makefile              |   4 +
 sound/soc/intel/boards/bytcr_nocodec.c       | 233 ++++++++++++++++++
 sound/soc/intel/boards/bytcr_rt5640.c        | 266 ++++++++++++++++-----
 sound/soc/intel/boards/bytcr_rt5651.c        | 338 +++++++++++++++++++++++++++
 sound/soc/intel/boards/cht_bsw_max98090_ti.c |  12 +
 sound/soc/intel/boards/cht_bsw_rt5645.c      |  12 +
 sound/soc/intel/boards/cht_bsw_rt5672.c      |  12 +
 sound/soc/intel/common/Makefile              |   5 +
 17 files changed, 1036 insertions(+), 72 deletions(-)
 create mode 100644 sound/soc/intel/boards/bytcr_nocodec.c
 create mode 100644 sound/soc/intel/boards/bytcr_rt5651.c

-- 
1.9.1

[PATCH 18/19] ASoC: Intel: Atom: add support for RT5642

[Pierre-Louis Bossart]

The machine driver is not loaded when the BIOS uses the 10EC5642
_HID. Add it to the white list of known _HIDs, codec_name is
already taken care of by previous commit

Tested on Asus T100TAF.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/intel/atom/sst/sst_acpi.c   | 2 ++
 sound/soc/intel/boards/bytcr_rt5640.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c
index f61e531..510826f 100644
--- a/sound/soc/intel/atom/sst/sst_acpi.c
+++ b/sound/soc/intel/atom/sst/sst_acpi.c
@@ -323,6 +323,8 @@ static int sst_acpi_remove(struct platform_device *pdev)
 static struct sst_acpi_mach sst_acpi_bytcr[] = {
 	{"10EC5640", "bytcr_rt5640", "intel/fw_sst_0f28.bin", "bytcr_rt5640", NULL,
 						&byt_rvp_platform_data },
+	{"10EC5642", "bytcr_rt5640", "intel/fw_sst_0f28.bin", "bytcr_rt5640", NULL,
+						&byt_rvp_platform_data },
 	{"10EC5651", "bytcr_rt5651", "intel/fw_sst_0f28.bin", "bytcr_rt5651", NULL,
 						&byt_rvp_platform_data },
 
diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index 74bb7cc..5b0cdad 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -302,7 +302,7 @@ static struct snd_soc_dai_link byt_rt5640_dais[] = {
 		.platform_name = "sst-mfld-platform",
 		.no_pcm = 1,
 		.codec_dai_name = "rt5640-aif1",
-		.codec_name = "i2c-10EC5640:00",
+		.codec_name = "i2c-10EC5640:00", /* overwritten with HID */
 		.dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
 						| SND_SOC_DAIFMT_CBS_CFS,
 		.be_hw_params_fixup = byt_rt5640_codec_fixup,
-- 
1.9.1