From: Mengdong Lin <mengdong.lin@linux.intel.com>
To: Mark Brown <broonie@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
mengdong.lin@intel.com, liam.r.girdwood@linux.intel.com,
jeeja.kp@intel.com, subhransu.s.prusty@intel.com
Subject: Re: [PATCH v2 2/3] ASoC: topology: Add FE DAIs dynamically
Date: Tue, 16 Feb 2016 14:22:52 +0800 [thread overview]
Message-ID: <56C2C03C.2060203@linux.intel.com> (raw)
In-Reply-To: <20160215193542.GA18327@sirena.org.uk>
On 02/16/2016 03:35 AM, Mark Brown wrote:
> On Wed, Jan 27, 2016 at 10:56:39AM +0100, Lars-Peter Clausen wrote:
>> On 01/15/2016 09:13 AM, mengdong.lin@linux.intel.com wrote:
>> [...]
>>> + stream->rates = snd_pcm_rate_range_to_bits(caps->rate_min,
>>> + caps->rate_max);
>
>> How about just setting stream->rate_min and stream->rate_max?
>
> I'll apply this but please send a followup patch fixing this.
>
I've sent out a patch to fix this:
[PATCH] ASoC: topology: Fix setting of stream rates, rate_min and rate_max
Please review and overlook my v3 series which just merged this fix with
the applied patches.
Thanks
Mengdong
next prev parent reply other threads:[~2016-02-16 6:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 8:11 [PATCH v2 0/3] ASoC: topology: Add support for FE DAI & DAI links mengdong.lin
2016-01-15 8:13 ` [PATCH v2 1/3] ALSA: pcm: Add snd_pcm_rate_range_to_bits() mengdong.lin
2016-02-05 18:53 ` Applied "ALSA: pcm: Add snd_pcm_rate_range_to_bits()" to the asoc tree Mark Brown
2016-01-15 8:13 ` [PATCH v2 2/3] ASoC: topology: Add FE DAIs dynamically mengdong.lin
2016-01-27 9:56 ` Lars-Peter Clausen
2016-02-15 19:35 ` Mark Brown
2016-02-16 6:22 ` Mengdong Lin [this message]
2016-02-16 5:35 ` Mengdong Lin
2016-01-15 8:13 ` [PATCH v2 3/3] ASoC: topology: Add FE DAI links dynamically mengdong.lin
2016-01-25 11:37 ` [PATCH v2 0/3] ASoC: topology: Add support for FE DAI & DAI links Liam Girdwood
2016-01-25 15:39 ` Mark Brown
2016-01-25 15:45 ` Takashi Iwai
2016-01-27 8:03 ` Mengdong Lin
2016-01-27 13:33 ` Mark Brown
2016-02-15 18:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C2C03C.2060203@linux.intel.com \
--to=mengdong.lin@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=lars@metafoo.de \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mengdong.lin@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).