[PATCH] ASoC: topology: Fix setting of stream rates, rate_min and rate_max

[PATCH] ASoC: topology: Fix setting of stream rates, rate_min and rate_max

[mengdong.lin]

From: Mengdong Lin <mengdong.lin@linux.intel.com>

Directly set a stream's rates, rate_min and rate_max from the topology
info. Also define set_stream_info to wrap setting of the stream info.

Signed-off-by: Mengdong Lin <mengdong.lin@linux.intel.com>

diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c
index 0eb01e8..2f7da32 100644
--- a/sound/soc/soc-topology.c
+++ b/sound/soc/soc-topology.c
@@ -1575,6 +1575,18 @@ static int soc_tplg_dapm_complete(struct soc_tplg *tplg)
 	return 0;
 }
 
+static int set_stream_info(struct snd_soc_pcm_stream *stream,
+	struct snd_soc_tplg_stream_caps *caps)
+{
+	stream->stream_name = kstrdup(caps->name, GFP_KERNEL);
+	stream->channels_min = caps->channels_min;
+	stream->channels_max = caps->channels_max;
+	stream->rates = caps->rates;
+	stream->rate_min = caps->rate_min;
+	stream->rate_max = caps->rate_max;
+	stream->formats = caps->formats;
+}
+
 static int soc_tplg_dai_create(struct soc_tplg *tplg,
 	struct snd_soc_tplg_pcm *pcm)
 {
@@ -1593,25 +1605,13 @@ static int soc_tplg_dai_create(struct soc_tplg *tplg,
 	if (pcm->playback) {
 		stream = &dai_drv->playback;
 		caps = &pcm->caps[SND_SOC_TPLG_STREAM_PLAYBACK];
-
-		stream->stream_name = kstrdup(caps->name, GFP_KERNEL);
-		stream->channels_min = caps->channels_min;
-		stream->channels_max = caps->channels_max;
-		stream->rates = snd_pcm_rate_range_to_bits(caps->rate_min,
-							caps->rate_max);
-		stream->formats = caps->formats;
+		set_stream_info(stream, caps);
 	}
 
 	if (pcm->capture) {
 		stream = &dai_drv->capture;
 		caps = &pcm->caps[SND_SOC_TPLG_STREAM_CAPTURE];
-
-		stream->stream_name = kstrdup(caps->name, GFP_KERNEL);
-		stream->channels_min = caps->channels_min;
-		stream->channels_max = caps->channels_max;
-		stream->rates = snd_pcm_rate_range_to_bits(caps->rate_min,
-							caps->rate_max);
-		stream->formats = caps->formats;
+		set_stream_info(stream, caps);
 	}
 
 	/* pass control to component driver for optional further init */
-- 
2.5.0

Re: [PATCH] ASoC: topology: Fix setting of stream rates, rate_min and rate_max

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 306 bytes --]

On Tue, Feb 16, 2016 at 02:27:32PM +0800, kbuild test robot wrote:

>    sound/soc/soc-topology.c: In function 'set_stream_info':
> >> sound/soc/soc-topology.c:1588:1: warning: no return statement in function returning non-void [-Wreturn-type]
>     }
>     ^

This is a real bug that 0day has identified.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: topology: Fix setting of stream rates, rate_min and rate_max

[Mengdong Lin]

On 02/20/2016 12:16 AM, Mark Brown wrote:
> On Tue, Feb 16, 2016 at 02:27:32PM +0800, kbuild test robot wrote:
>
>>     sound/soc/soc-topology.c: In function 'set_stream_info':
>>>> sound/soc/soc-topology.c:1588:1: warning: no return statement in function returning non-void [-Wreturn-type]
>>      }
>>      ^
>
> This is a real bug that 0day has identified.
>

I'm sorry for the bug. Fixed this in v2 patch.

Thanks
Mengdong