Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>,
	tiwai@suse.de, perex@perex.cz
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 5/6] control: add a function to add an	element of bytes type
Date: Tue, 23 Feb 2016 09:31:42 +0100	[thread overview]
Message-ID: <56CC18EE.1070800@ladisch.de> (raw)
In-Reply-To: <1456188510-7189-6-git-send-email-o-takashi@sakamocchi.jp>

Takashi Sakamoto wrote:
> ALSA Ctl core allows userspace applications to add elements of bytes type,
> while there's no APIs for this purpose in alsa-lib.
>
> This commit adds the missing function.

>  /**
> + * \brief Create and add an user-defined control element of bytes type.
> + * \param[in] ctl CTL handle.
> + * \param[in,out] id ID of the new control element.
> + * \param[in] channels The number of channels which a control element includes.

For this control type, "count" might be a better name.
Or at least say in the description that this is the number of bytes.


Regards,
Clemens

  reply	other threads:[~2016-02-23  8:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23  0:48 [alsa-lib][PATCH 0/6] control: add APIs for control element set Takashi Sakamoto
2016-02-23  0:48 ` [PATCH 1/6] control: rename variables so that it represents the number of channels which an element has Takashi Sakamoto
2016-02-23  8:52   ` Takashi Sakamoto
2016-02-23  0:48 ` [PATCH 2/6] control: improve API documentation for functions to add elements Takashi Sakamoto
2016-02-23  0:48 ` [PATCH 3/6] control: improve API documentation for functions to set/get channel values for an element Takashi Sakamoto
2016-02-23  0:48 ` [PATCH 4/6] control: rename variables so that it represents a channel in element Takashi Sakamoto
2016-02-23  0:48 ` [PATCH 5/6] control: add a function to add an element of bytes type Takashi Sakamoto
2016-02-23  8:31   ` Clemens Ladisch [this message]
2016-02-23  9:22     ` Takashi Sakamoto
2016-02-23  9:37       ` Takashi Iwai
2016-02-23  0:48 ` [PATCH 6/6] control: add functions to add element set Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CC18EE.1070800@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=o-takashi@sakamocchi.jp \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox