From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Tinkham Subject: Re: [PATCH] sound/soc/tegra: tegra_max98090: fix hp detect on Chromebook 13 Date: Wed, 24 Feb 2016 09:43:39 -0700 Message-ID: <56CDDDBB.3080709@gmail.com> References: <56CB6624.6030600@wwwdotorg.org> <1456247985-5563-1-git-send-email-sctincman@gmail.com> <20160224032552.GJ18327@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160224032552.GJ18327-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: alsa-devel@alsa-project.org On 02/23/2016 08:25 PM, Mark Brown wrote: > On Tue, Feb 23, 2016 at 10:19:44AM -0700, Jonathan Tinkham wrote: > >> Jonathan Tinkham (1): >> sound/soc/tegra: tegra_max98090: Invert headphone by GPIO flag > I have *repeatedly* reminded you to use subject lines reflecting the > style for the subsystem and you continue to ignore me. Please don't > ignore review comments, people are generally making them for a reason > and are likely to have the same concerns if issues remain unaddressed. > Having to repeat the same comments can get repetitive and make people > question the value of time spent reviewing. If you disagree with the > concerns so that the reviewer can understand your decisions. Yes, my apologies. I continually misunderstood your comments