From: Lars-Peter Clausen <lars@metafoo.de>
To: Jose Abreu <Jose.Abreu@synopsys.com>,
linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org
Cc: Vineet.Gupta1@synopsys.com, Alexey.Brodkin@synopsys.com,
CARLOS.PALMINHA@synopsys.com, lgirdwood@gmail.com,
broonie@kernel.org, tiwai@suse.com
Subject: Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support
Date: Mon, 11 Apr 2016 11:33:47 +0200 [thread overview]
Message-ID: <570B6F7B.2020906@metafoo.de> (raw)
In-Reply-To: <570B6DF2.1080008@synopsys.com>
On 04/11/2016 11:27 AM, Jose Abreu wrote:
> Hi Lars,
>
>
> On 09-04-2016 16:02, Lars-Peter Clausen wrote:
>> On 04/08/2016 06:12 PM, Jose Abreu wrote:
>> [...]
>>>> [...]
>>>>> +- adi,enable-audio: If set the ADV7511 driver will register a codec interface
>>>>> + into ALSA SoC.
>>>> This is not a description of the hardware.
>>> Is this okay: "adi,enable-audio: Set this boolean parameter if ADV7511
>>> transmitter routes audio signals" ?
>> I don't think we need this property. There is no problem with registering
>> the audio part unconditionally. As long as there is no connection we wont
>> create a sound card that is exposed to userspace.
>>
>
> This change was suggested by Laurent Pinchart and was introduced in v3. Quoting
> Laurent:
> "The idea is that enabling support for ADV7511 audio in the kernel isn't coupled
> with whether the system includes audio support. It would be confusing, and would
> also waste resources, to create a Linux sound device when no sound channel is
> routed on the board."
I wouldn't care too much about this at this point, the extra amount of
resources required for registering the CODEC (but not the sound card) is
just a few bytes (sizeof(struct snd_soc_codec)).
Nevertheless what we should do is describe the hardware and from this
information infer whether there is a audio connection or not and if there is
none we might skip registering the CODEC. In my opinion this hardware
description should be modeled using of-graph, having a connection between
the SoC side and the adv7511 SPDIF or I2S port.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-04-11 9:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 16:53 [PATCH 0/5 v4] Add I2S/ADV7511 audio support for ARC AXS10x boards Jose Abreu
2016-04-07 16:53 ` [PATCH 1/5 v4] drm/i2c/adv7511: Rename and move to separate folder Jose Abreu
2016-04-07 16:53 ` [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support Jose Abreu
2016-04-08 15:46 ` [alsa-devel] " Lars-Peter Clausen
2016-04-08 16:12 ` Jose Abreu
2016-04-09 15:02 ` [alsa-devel] " Lars-Peter Clausen
2016-04-11 9:27 ` Jose Abreu
2016-04-11 9:33 ` Lars-Peter Clausen [this message]
2016-04-11 11:32 ` Jose Abreu
2016-04-11 12:23 ` [alsa-devel] " Lars-Peter Clausen
2016-04-11 14:08 ` Jose Abreu
2016-04-11 19:34 ` [alsa-devel] " Lars-Peter Clausen
2016-04-07 16:53 ` [PATCH 3/5 v4] ASoC: dwc: Use fifo depth to program FCR Jose Abreu
2016-04-07 17:57 ` Applied "ASoC: dwc: Use fifo depth to program FCR" to the asoc tree Mark Brown
2016-04-07 16:53 ` [PATCH 4/5 v4] ASoC: dwc: Add custom PCM driver Jose Abreu
2016-04-07 17:54 ` kbuild test robot
2016-04-07 16:53 ` [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver Jose Abreu
2016-04-07 17:53 ` Mark Brown
2016-04-08 10:06 ` Jose Abreu
2016-04-08 15:52 ` [alsa-devel] " Lars-Peter Clausen
2016-04-08 16:08 ` Jose Abreu
2016-04-09 14:55 ` Lars-Peter Clausen
2016-04-11 9:24 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570B6F7B.2020906@metafoo.de \
--to=lars@metafoo.de \
--cc=Alexey.Brodkin@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).