From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
alsa-devel@alsa-project.org
Cc: tiwai@suse.de, patches.audio@intel.com, broonie@kernel.org,
lgirdwood@gmail.com, Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH 05/11] ASoC: hdac_hdmi: Add multichannel support
Date: Tue, 12 Apr 2016 07:25:33 -0500 [thread overview]
Message-ID: <570CE93D.6000109@linux.intel.com> (raw)
In-Reply-To: <1460437293-8509-6-git-send-email-subhransu.s.prusty@intel.com>
- /* Only stereo supported as of now */
- cvt->params.channels_min = cvt->params.channels_max = 2;
+ chans = get_wcaps(hdac, cvt->nid);
+ chans = get_wcaps_channels(chans);
+
+ cvt->params.channels_min = 2;
+
+ if (chans <= 16) {
+ cvt->params.channels_max = chans;
+ if (chans > hdmi->chmap.channels_max)
+ hdmi->chmap.channels_max = chans;
+ }t
Are you sure about this? HDMI can only handle 8 channels in Layout 2.
There's no support for 16 ch.
next prev parent reply other threads:[~2016-04-12 12:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 5:01 [PATCH 00/11] ASoC: hdac_hdmi: Add multichannel support Subhransu S. Prusty
2016-04-12 5:01 ` [PATCH 01/11] ASoC: Intel: Skylake: Fix ibs/obs calc for non-integral sampling rates Subhransu S. Prusty
2016-04-12 6:30 ` Applied "ASoC: Intel: Skylake: Fix ibs/obs calc for non-integral sampling rates" to the asoc tree Mark Brown
2016-04-12 5:01 ` [PATCH 02/11] drm/edid: Add API to get speaker allocation Subhransu S. Prusty
2016-04-12 5:01 ` [PATCH 03/11] ASoC: hdac_hdmi: parse eld for channel map capability Subhransu S. Prusty
2016-04-12 5:01 ` [PATCH 04/11] ALSA: hda - add helper to get channels from cap bits Subhransu S. Prusty
2016-04-12 5:01 ` [PATCH 05/11] ASoC: hdac_hdmi: Add multichannel support Subhransu S. Prusty
2016-04-12 12:25 ` Pierre-Louis Bossart [this message]
2016-04-12 13:36 ` Subhransu S. Prusty
2016-04-12 13:50 ` Takashi Iwai
2016-04-12 5:01 ` [PATCH 06/11] ASoC: skl_rt286: Fix to support hdmi channel map support Subhransu S. Prusty
2016-04-12 5:01 ` [PATCH 07/11] ASoC: Intel: boards: Update skl_nau88l25_max98357a driver to support chmap Subhransu S. Prusty
2016-04-12 5:01 ` [PATCH 08/11] ASoC: Intel: boards: Update skl_nau88l25_ssm4567 " Subhransu S. Prusty
2016-04-12 12:32 ` Pierre-Louis Bossart
2016-04-12 13:51 ` Subhransu S. Prusty
2016-04-12 5:01 ` [PATCH 09/11] ASoC: hdac_hdmi: Register chmap controls and ops Subhransu S. Prusty
2016-04-28 17:55 ` Applied "ASoC: hdac_hdmi: Register chmap controls and ops" to the asoc tree Mark Brown
2016-04-12 5:01 ` [PATCH 10/11] ASoC: Intel: Skylake: Add multichannel support for HDMI Subhransu S. Prusty
2016-04-28 17:55 ` Applied "ASoC: Intel: Skylake: Add multichannel support for HDMI" to the asoc tree Mark Brown
2016-04-12 5:01 ` [PATCH 11/11] ASoC: Intel: Skylake: Update channel map based on runtime params Subhransu S. Prusty
2016-04-28 17:55 ` Applied "ASoC: Intel: Skylake: Update channel map based on runtime params" to the asoc tree Mark Brown
2016-04-12 5:43 ` [PATCH 00/11] ASoC: hdac_hdmi: Add multichannel support Takashi Iwai
2016-04-12 5:54 ` Mark Brown
2016-04-12 6:26 ` Subhransu S. Prusty
2016-04-12 6:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570CE93D.6000109@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).