From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [PATCH v2] ASoC: Intel: Skylake: enable S24_LE format support Date: Sat, 23 Mar 2019 09:39:37 -0400 Message-ID: <570ed8a0-a83a-9da5-082a-2ce68a39d367@linux.intel.com> References: <1553346610-1012-1-git-send-email-jenny.tc@intel.corp-partner.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 86401F801DB for ; Sat, 23 Mar 2019 14:39:42 +0100 (CET) In-Reply-To: <1553346610-1012-1-git-send-email-jenny.tc@intel.corp-partner.google.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Jenny TC , alsa-devel@alsa-project.org, Liam Girdwood , Jie Yang , Mark Brown , Jaroslav Kysela , Takashi Iwai , Ughreja Rakesh A , Periyasamy SriramX , Kumar Abhijeet , Kale Sanyog R Cc: N Harshapriya , M Naveen , M R Sathya Prakash , Jenny TC , Nujella Sathyanarayana List-Id: alsa-devel@alsa-project.org On 3/23/19 9:10 AM, Jenny TC wrote: > From: Jenny TC > > To enable S24_LE format, sample_type in topology fw has to be set to 1. > But sample_type defined in topology firmware configuration is not > getting reflected in the dsp param. This patch sets sample_type in base > config so that the sample type defined in the topology firmware is reflected > in the dsp params. This issues was uncovered while debugging the S24_LE format > which require the MSB byte in 32 bit word to be skipped. Setting sample_type > in topology firmware to 1 helps to skip MSB byte word. > > Signed-off-by: Jenny TC Acked-by: Pierre-Louis Bossart > --- > sound/soc/intel/skylake/skl-messages.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c > index 28c4806..4bf70b4 100644 > --- a/sound/soc/intel/skylake/skl-messages.c > +++ b/sound/soc/intel/skylake/skl-messages.c > @@ -483,6 +483,7 @@ static void skl_set_base_module_format(struct skl_sst *ctx, > base_cfg->audio_fmt.bit_depth = format->bit_depth; > base_cfg->audio_fmt.valid_bit_depth = format->valid_bit_depth; > base_cfg->audio_fmt.ch_cfg = format->ch_cfg; > + base_cfg->audio_fmt.sample_type = format->sample_type; > > dev_dbg(ctx->dev, "bit_depth=%x valid_bd=%x ch_config=%x\n", > format->bit_depth, format->valid_bit_depth, >