From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [PATCH] ASoC: tlv320aix31xx: Add ACPI match for Lenovo 100S Date: Tue, 19 Apr 2016 14:25:33 -0500 Message-ID: <5716862D.2020309@linux.intel.com> References: <1461081620-23378-1-git-send-email-hadess@hadess.net> <20160419164107.GY3217@sirena.org.uk> <57167194.2030803@linux.intel.com> <20160419184323.GF3217@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by alsa0.perex.cz (Postfix) with ESMTP id 4A8B7264F39 for ; Tue, 19 Apr 2016 21:25:37 +0200 (CEST) In-Reply-To: <20160419184323.GF3217@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Liam Girdwood , Bastien Nocera List-Id: alsa-devel@alsa-project.org On 04/19/2016 01:43 PM, Mark Brown wrote: > On Tue, Apr 19, 2016 at 12:57:40PM -0500, Pierre-Louis Bossart wrote: >> On 04/19/2016 11:41 AM, Mark Brown wrote: >>> On Tue, Apr 19, 2016 at 06:00:20PM +0200, Bastien Nocera wrote: >>>> +static const struct acpi_device_id aic31xx_acpi_match[] = { >>>> + { "10TI3100", 0 }, >>> An ACPI identifier that actually bears some resemblance to the name of >>> the part, will wonders never cease! :) >> It's not a legit ACPI id but at least it's consistent with other BIOS. I see >> the same in a couple of DSDT I extracted. it'd be curious to see the >> schematics if you have them to help progress with Baytrail-CR support. > It's in the right form at least, dunno if TI actually registered 10TI > properly or not though. The PNP ID for TI is TXN The ACPI ID is TXNW TI's PCI ID is 0x104C. so nope, none of the legit vendor IDs match 10TI, which doesn't follow the rules... No one seems to care in the BIOS world though, it's becoming a lost cause.