From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH 1/7] ASoC: mediatek: Refine mt8173 driver and change config option Date: Thu, 5 May 2016 10:32:17 +0200 Message-ID: <572B0511.80701@gmail.com> References: <1461934848-60011-1-git-send-email-garlic.tseng@mediatek.com> <1461934848-60011-2-git-send-email-garlic.tseng@mediatek.com> <20160504164306.GA6292@sirena.org.uk> <1462416342.25179.36.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by alsa0.perex.cz (Postfix) with ESMTP id E137B261AFF for ; Thu, 5 May 2016 10:32:24 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id e201so11150476wme.0 for ; Thu, 05 May 2016 01:32:24 -0700 (PDT) In-Reply-To: <1462416342.25179.36.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Garlic Tseng , Mark Brown Cc: alsa-devel@alsa-project.org, ir.lian@mediatek.com, srv_heupstream@mediatek.com, tiwai@suse.de, koro.chen@mediatek.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, PC.Liao@mediatek.com, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On 05/05/16 04:45, Garlic Tseng wrote: > On Wed, 2016-05-04 at 17:43 +0100, Mark Brown wrote: >> On Fri, Apr 29, 2016 at 09:00:42PM +0800, Garlic Tseng wrote: >> >>> .../{mtk-afe-pcm.c => mt8173/mt8173-afe-pcm.c} | 488 ++++++++++----------- >> >> So there's going to be no code sharing at all between this and any other >> Mediatek chips? That seems very surprising, it'd suggest that the >> hardware designers were creating a new design completely from scratch >> each time which doesn't seem all that likely. This is an unusual way of >> organizing things and we need a much clearer explanation of what's going >> on here. > > MT8173 and MT2701 are from different product lines so the register > control sequences are very different. If another driver for 8173-like > (or 2701-like) chip go upstream it shall share some common code with the > relatively driver indeed. However I think MT8173 and MT2701 can't share > the platform driver or a lot of "if MT8173 else MT2701" will mess up the > code. > What about the other SoCs we have some minimal support for: mt6589, mt8135, mt6592, mt6580, mt7323, mt8127? A quick glance at the datasheets showed me, that mt6589 and at least mt8127 have quite similar register offsets. So I suppose there is some common code actually. Regards, Matthias