From: John Hsu <KCHSU0@nuvoton.com>
To: Mark Brown <broonie@kernel.org>
Cc: AP MS30 Linux ALSA <alsa-devel@alsa-project.org>,
"anatol.pomozov@gmail.com" <anatol.pomozov@gmail.com>,
AC30 YHChuang <YHCHuang@nuvoton.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"benzh@chromium.org" <benzh@chromium.org>,
AC30 CTLin0 <CTLIN0@nuvoton.com>, MS40 MHKuo <MHKuo@nuvoton.com>,
"yong.zhi@intel.com" <yong.zhi@intel.com>
Subject: Re: [PATCH 1/2 v2] ASoC: nau8825: non-clock jack detection for power saving at standby
Date: Tue, 24 May 2016 11:41:02 +0800 [thread overview]
Message-ID: <5743CD4E.6020805@nuvoton.com> (raw)
In-Reply-To: <20160523170432.GA8206@sirena.org.uk>
Hi,
On 5/24/2016 1:04 AM, Mark Brown wrote:
> On Mon, May 23, 2016 at 09:59:54AM +0800, John Hsu wrote:
>
>> On 5/20/2016 7:01 PM, Mark Brown wrote:
>>
>
>
>>> I understand what it's doing but obviously a biquad filter isn't
>>> specialized for this function...
>>>
>
>
>> Yes, the biquad filter is general purpose feature. Could you give us
>> suggestion about how to implement the biquad filter for common fea-
>> ture and to fix DC offset as well?
>>
>
> The trouble is you'd have to do the configuration in userspace or do
> something like only do the DC offset correction if no other filter is
> configured. TBH it's not unreasonable to suggest people should just
> configured a high pass filter if they're having issues, though it's a
> bit more work :(
>
Is it acceptable if we change our patch to do the DC offset correction
instead of general BIQ filter for the issue?
next prev parent reply other threads:[~2016-05-24 3:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 9:17 [PATCH 1/2 v2] ASoC: nau8825: non-clock jack detection for power saving at standby John Hsu
2016-05-13 10:48 ` Mark Brown
2016-05-16 1:47 ` John Hsu
2016-05-18 17:05 ` Mark Brown
2016-05-20 3:12 ` John Hsu
2016-05-20 11:01 ` Mark Brown
2016-05-23 1:59 ` John Hsu
2016-05-23 17:04 ` Mark Brown
2016-05-24 3:41 ` John Hsu [this message]
2016-05-24 11:03 ` Mark Brown
2016-05-30 2:00 ` John Hsu
2016-05-30 15:16 ` Mark Brown
2016-05-13 13:26 ` Applied "ASoC: nau8825: non-clock jack detection for power saving at standby" to the asoc tree Mark Brown
2016-05-13 13:34 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2016-05-16 8:55 [PATCH 1/2 v2] ASoC: nau8825: non-clock jack detection for power saving at standby John Hsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5743CD4E.6020805@nuvoton.com \
--to=kchsu0@nuvoton.com \
--cc=CTLIN0@nuvoton.com \
--cc=MHKuo@nuvoton.com \
--cc=YHCHuang@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=anatol.pomozov@gmail.com \
--cc=benzh@chromium.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).