From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
b.zolnierkie@samsung.com, inki.dae@samsung.com,
broonie@kernel.org, ideal.song@samsung.com
Subject: Re: [PATCH v1 1/2] ASoC: Add DT bindings documentation for max98504 amplifier
Date: Mon, 20 Jun 2016 15:49:17 +0200 [thread overview]
Message-ID: <5767F45D.5040404@samsung.com> (raw)
In-Reply-To: <20160620131522.GA27923@rob-hp-laptop>
On 06/20/2016 03:15 PM, Rob Herring wrote:
>> diff --git a/Documentation/devicetree/bindings/sound/max98504.txt
>> b/Documentation/devicetree/bindings/sound/max98504.txt
>> > new file mode 100644
>> > index 0000000..7aa5b93
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/sound/max98504.txt
>> > @@ -0,0 +1,22 @@
>> > +Maxim MAX98504 class D mono speaker amplifier
>> > +
>> > +This device supports I2C control interface and an IRQ output signal. It features
>> > +a PCM and PDM digital audio interface (DAI) and a differential analog input.
>
> Where's the IRQ in the binding?
It seems I didn't do my homework and didn't add it here, even though
the driver currently uses the interrupt. I'll add something like this
in next iteration:
- interrupts : should specify the interrupt the device is connected to,
as described in ../interrupt-controller/interrupts.txt
prev parent reply other threads:[~2016-06-20 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 16:40 [PATCH v1 1/2] ASoC: Add DT bindings documentation for max98504 amplifier Sylwester Nawrocki
[not found] ` <1466095238-9047-1-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-06-16 16:40 ` [PATCH v1 2/2] ASoC: max98504: Add max98504 speaker amplifier driver Sylwester Nawrocki
2016-06-20 13:15 ` [PATCH v1 1/2] ASoC: Add DT bindings documentation for max98504 amplifier Rob Herring
2016-06-20 13:49 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5767F45D.5040404@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ideal.song@samsung.com \
--cc=inki.dae@samsung.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox