From: Lars-Peter Clausen <lars@metafoo.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Vinod Koul <vinod.koul@intel.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-renesas-soc@vger.kernel.org, Simon <horms@verge.net.au>
Subject: Re: [alsa-devel] Question about struct snd_soc_dai() :: cpu_dai->codec
Date: Thu, 28 Jul 2016 22:43:54 +0200 [thread overview]
Message-ID: <579A6E8A.6060405@metafoo.de> (raw)
In-Reply-To: <s5ha8h15wav.wl-tiwai@suse.de>
On 07/28/2016 10:42 PM, Takashi Iwai wrote:
> On Thu, 28 Jul 2016 22:33:31 +0200,
> Lars-Peter Clausen wrote:
>>
>> On 07/28/2016 05:46 AM, Vinod Koul wrote:
>>> On Wed, Jul 27, 2016 at 10:22:41PM +0200, Takashi Iwai wrote:
>>>> On Wed, 27 Jul 2016 20:22:33 +0200,
>>>> Mark Brown wrote:
>>>>>
>>>>> On Wed, Jul 27, 2016 at 08:11:49PM +0200, Takashi Iwai wrote:
>>>>>
>>>>>> I'm wondering whether it's a better option to block the unbind
>>>>>> behavior, either in driver base (allowing to return an error) or in
>>>>>> the sound side (waiting in remove() until the sane point).
>>>>>
>>>>> That's certainly going to be a lot easier and part of the reason it's
>>>>> never been looked at much is that (unlike USB) there's very little
>>>>> reason why an ASoC sound card would ever be hotplugged - even in
>>>>> development these days the normal development flow involves rebooting.
>>>
>>> I agree, it makese no sense for devices to be hotplugged. And for
>>> developement flows people can do rmmond and insmod. That works fine!
>>
>> I don't agree. In my opinion hot-plug is an essential feature of a
>> modern device driver framework and if ASoC wants to claim to fall in
>> this category we ought to support it. Hotplug is something that always
>> pops up sooner or later. E.g. if someone puts a ASoC supported CODEC on
>> a hot-pluggable device (maybe USB) we don't want to duplicate the code,
>> but be able to reuse.
>>
>> One area that e.g. requires hot-plug/-unplug and were ASoC supported
>> devices are used is embedded development boards that support shields and
>> devicetree overlays. Like e.g. RPI and similar.
>>
>> The reason why we don't support hot-unplug in ASoC at the moment is
>> because it is not trivial to implement and nobody has cared enough yet.
>>
>> But if somebody wants to and has the resources to implement this we
>> should not discourage this.
>>
>> I'd very much prefer to have proper hot-plug support instead of
>> prohibiting unbinding even on systems that do not require hot-plug
>> support normally. It's a much cleaner solution.
>
> Well, but hot-unplugging only a component like codec would be needed
> in a real scenario? It's a different story from the hotplug in the
> card level.
With overlays I'm not sure if we can control the remove order. So the
component might be removed before the card complex.
next prev parent reply other threads:[~2016-07-28 20:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 5:41 Question about struct snd_soc_dai() :: cpu_dai->codec Kuninori Morimoto
2016-07-27 3:21 ` [alsa-devel] " Vinod Koul
2016-07-27 3:42 ` Kuninori Morimoto
2016-07-27 5:57 ` Takashi Iwai
2016-07-27 6:36 ` Kuninori Morimoto
2016-07-27 17:21 ` Vinod Koul
2016-07-27 18:04 ` Mark Brown
2016-07-27 18:11 ` Takashi Iwai
2016-07-27 18:22 ` Mark Brown
2016-07-27 20:22 ` Takashi Iwai
2016-07-28 3:46 ` Vinod Koul
2016-07-28 20:33 ` Lars-Peter Clausen
2016-07-28 20:42 ` Takashi Iwai
2016-07-28 20:43 ` Lars-Peter Clausen [this message]
2016-07-28 20:44 ` Mark Brown
2016-07-29 0:30 ` Takashi Sakamoto
2016-07-29 9:07 ` Lars-Peter Clausen
2016-07-29 16:07 ` Vinod Koul
2016-07-29 20:41 ` Takashi Iwai
2016-07-29 21:45 ` Takashi Sakamoto
2016-07-29 22:08 ` Mark Brown
2016-08-04 3:17 ` Takashi Sakamoto
2016-08-04 10:28 ` Mark Brown
2016-08-04 12:12 ` Takashi Sakamoto
2016-08-04 12:27 ` Takashi Iwai
2016-08-04 13:39 ` Takashi Sakamoto
2016-08-04 13:52 ` Takashi Iwai
2016-07-28 20:24 ` [alsa-devel] " Lars-Peter Clausen
2016-07-29 2:24 ` Kuninori Morimoto
2016-07-29 9:01 ` Lars-Peter Clausen
2016-07-29 14:41 ` Mark Brown
2016-08-01 3:45 ` Kuninori Morimoto
2016-08-02 6:47 ` Kuninori Morimoto
2016-08-03 19:32 ` [alsa-devel] " Lars-Peter Clausen
2016-08-04 2:38 ` Kuninori Morimoto
2016-08-04 8:21 ` Lars-Peter Clausen
2016-08-04 20:56 ` [alsa-devel] " Mark Brown
2016-08-05 7:29 ` Kuninori Morimoto
2016-08-04 20:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579A6E8A.6060405@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).