From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Hsu <KCHSU0@nuvoton.com>
Subject: Re: [PATCH] ASoC: nau8810: Add driver for Nuvoton
	codec chip NAU88C10
Date: Tue, 9 Aug 2016 10:09:11 +0800
Message-ID: <57A93B47.3000608@nuvoton.com>
References: <1466152834-29615-1-git-send-email-KCHSU0@nuvoton.com>
 <20160627171546.GE17217@sirena.org.uk> <5775E4C7.5010303@nuvoton.com>
 <20160701100423.GM6247@sirena.org.uk> <5779D93B.80106@nuvoton.com>
 <20160805120804.GV10383@sirena.org.uk> <57A7EE1A.1040307@nuvoton.com>
 <20160808151813.GH10383@sirena.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from maillog.nuvoton.com (maillog.nuvoton.com [202.39.227.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 3DEFB2652CE
 for <alsa-devel@alsa-project.org>; Tue,  9 Aug 2016 04:09:14 +0200 (CEST)
In-Reply-To: <20160808151813.GH10383@sirena.org.uk>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Mark Brown <broonie@kernel.org>
Cc: WTLI@nuvoton.com, YHCHuang@nuvoton.com, alsa-devel@alsa-project.org, CTLIN0@nuvoton.com, lgirdwood@gmail.com
List-Id: alsa-devel@alsa-project.org

Hi,

On 8/8/2016 11:18 PM, Mark Brown wrote:
> On Mon, Aug 08, 2016 at 10:27:38AM +0800, John Hsu wrote:
>   
>> On 8/5/2016 8:08 PM, Mark Brown wrote:
>>     
>
>   
>>> What does the read actually look like on this device?
>>>       
>
>   
>> The data read from codec by the IIC bus is as the following.
>> 0 0 0 0 0 0 0 D8 ACK D7 D6 D5 D4 D3 D2 D1 D0
>> The bottom 9 bits are the real register value. The nau8810_reg_read
>> in driver is made by the formate.
>>     
>
> So there's really only one read "register"?  If that's the case I'd
> just open code the read and not bother with regmap, it's probably more
> trouble than it's worth.  There are other 7x9 CODECs that do the same
> thing.
>   

The most registers of the codec are for write function. Only a
little is read only, and they are all static value. I understand
your concern and agree that. I can take off the register read and
write function in the driver. Thanks for your advice.