Re: [PATCH 0/2] topology: Support widgets' stream name and file inclusion for text conf file

[Mengdong Lin <mengdong.lin@linux.intel.com>]

On 10/17/2016 08:49 PM, Takashi Iwai wrote:
> On Mon, 17 Oct 2016 07:55:21 +0200,
> mengdong.lin@linux.intel.com wrote:
>>
>> From: Mengdong Lin <mengdong.lin@linux.intel.com>
>>
>> This series doesn't require or cause any ABI updates. It doesn't need the
>> kernel patches that trying to udpate ABI from v4 or v5.
>>
>> It just fix a missing feature and enhance text conf file to support
>> including files to control the increasing size of text conf files.
>
> The inclusion of a file can be done in alsaconf syntax via <xxx>,
> too.  We may extend it if needed instead?


Thanks for your review and advice!

It seems etter to extend and reuse alsaconf syntax, instead of adding 
topology specific code. This can also benefit UCM if users want to split 
common codec or SOC settings to other files.

alsaconf already support using absolute path to include a file. But it 
seems we cannot give a relative path (e.g. just a file name) and a 
configuration directory by <confdir:xxx>. I'll try to extend alsaconf.

The other patch is a bug fixing, if it's okay, could it be merged first?

Thanks
Mengdong

>
> The patches themselves look OK, so I'm not strongly against merging
> them, but just to make sure our standpoint.
>
>
> thanks,
>
> Takashi
>
>>
>> Mengdong Lin (2):
>>    topology: Fix missing stream name of widgets in text conf file
>>    topology: Add support for included files
>>
>>   include/topology.h        |  38 +++++
>>   src/topology/dapm.c       |  10 ++
>>   src/topology/parser.c     | 374 +++++++++++++++++++++++++++++++++++++++++++++-
>>   src/topology/tplg_local.h |  17 +++
>>   4 files changed, 434 insertions(+), 5 deletions(-)
>>
>> --
>> 2.5.0
>>
>