Re: [PATCH 0/2] topology: Support widgets' stream name and file inclusion for text conf file

[Mengdong Lin <mengdong.lin@linux.intel.com>]

On 10/19/2016 11:45 AM, Vinod Koul wrote:
> On Mon, Oct 17, 2016 at 02:49:42PM +0200, Takashi Iwai wrote:
>> On Mon, 17 Oct 2016 07:55:21 +0200,
>> mengdong.lin@linux.intel.com wrote:
>>>
>>> From: Mengdong Lin <mengdong.lin@linux.intel.com>
>>>
>>> This series doesn't require or cause any ABI updates. It doesn't need the
>>> kernel patches that trying to udpate ABI from v4 or v5.
>>>
>>> It just fix a missing feature and enhance text conf file to support
>>> including files to control the increasing size of text conf files.
>>
>> The inclusion of a file can be done in alsaconf syntax via <xxx>,
>> too.  We may extend it if needed instead?
>
> Ah that's interesting... Am fine either way.

That saves a lot of code as well :-)

I sent out the v2 series which extends alsaconf and now topology does 
not need any code change. Please review.

Thanks
Mengdong

>
>> The patches themselves look OK, so I'm not strongly against merging
>> them, but just to make sure our standpoint.
>
> The last SKL conf became a bit bigger, so for readability we though we can
> have different files, one for module instances, one for tuples and then
> finally one including these two which has the graph..
>