From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org,
Sascha Hauer <s.hauer@pengutronix.de>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: tlv320aic3x: Fix mono
Date: Wed, 30 Jan 2013 12:17:28 +0100 (CET) [thread overview]
Message-ID: <582284253.632588.1359544648766.JavaMail.root@advansee.com> (raw)
In-Reply-To: <20130130021143.GC4945@opensource.wolfsonmicro.com>
On Wednesday, January 30, 2013 3:11:45 AM, Mark Brown wrote:
> On Tue, Jan 29, 2013 at 09:40:18PM +0100, Benoît Thébaudeau wrote:
> > On Tuesday, January 29, 2013 3:01:32 AM, Mark Brown wrote:
>
> > > Why are you having to call this in the first place?
>
> > For I²S, because the reference manual of the i.MX25 says that SSI.STCCR.DC
> > should be set to 1 (i.e. 2 channels) in this mode. This also allowed to
> > test
> > several settings for mono.
>
> > For DSP modes, because stereo doesn't work without this call (right channel
> > missing).
>
> So why does the driver not just do this automatically?
I don't know. I add Fabio and Sascha to Cc in case they know.
I think that it's either to let the users of imx-ssi do weird things if they
have to (but implementing a default setup would not prevent users to change it
by calling snd_soc_dai_set_tdm_slot(), so...), or rather because nobody had
enough time or all the test configurations to work on this so far. It's marked
as TODO in sound/soc/fsl/wm1133-ev1.c.
Best regards,
Benoît
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2013-01-30 11:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 17:19 [PATCH] ASoC: tlv320aic3x: Fix mono Benoît Thébaudeau
2013-01-26 8:55 ` Mark Brown
2013-01-26 14:17 ` Benoît Thébaudeau
2013-01-27 2:58 ` Mark Brown
2013-01-28 21:03 ` Benoît Thébaudeau
2013-01-29 2:01 ` Mark Brown
2013-01-29 20:40 ` Benoît Thébaudeau
2013-01-30 2:11 ` Mark Brown
2013-01-30 11:17 ` Benoît Thébaudeau [this message]
2013-01-29 20:31 ` [PATCH v2] ASoC: tlv320aic3x: Remove mono support Benoît Thébaudeau
2013-01-30 2:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582284253.632588.1359544648766.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=fabio.estevam@freescale.com \
--cc=lgirdwood@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).