From: <Codrin.Ciubotariu@microchip.com>
To: <linmq006@gmail.com>, <lgirdwood@gmail.com>, <broonie@kernel.org>,
<perex@perex.cz>, <tiwai@suse.com>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>, <Claudiu.Beznea@microchip.com>,
<florian.meier@koalo.de>, <alsa-devel@alsa-project.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: atmel: Fix error handling in snd_proto_probe
Date: Mon, 7 Mar 2022 13:45:48 +0000 [thread overview]
Message-ID: <582c39ac-3099-d54f-5de3-d54a4ace0a04@microchip.com> (raw)
In-Reply-To: <20220307130415.5720-1-linmq006@gmail.com>
On 07.03.2022 15:04, Miaoqian Lin wrote:
> @@ -136,18 +138,21 @@ static int snd_proto_probe(struct platform_device *pdev)
> dai_fmt |= snd_soc_daifmt_parse_clock_provider_as_flag(np, NULL);
> }
>
> - of_node_put(bitclkmaster);
> - of_node_put(framemaster);
> - dai->dai_fmt = dai_fmt;
>
> - of_node_put(codec_np);
> - of_node_put(cpu_np);
> + dai->dai_fmt = dai_fmt;
looks like there is an extra line that remains here
With this addressed, you can add:
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks!
next prev parent reply other threads:[~2022-03-07 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 13:04 [PATCH] ASoC: atmel: Fix error handling in snd_proto_probe Miaoqian Lin
2022-03-07 13:45 ` Codrin.Ciubotariu [this message]
2022-03-08 1:39 ` [PATCH v2] " Miaoqian Lin
2022-03-08 17:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582c39ac-3099-d54f-5de3-d54a4ace0a04@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=florian.meier@koalo.de \
--cc=lgirdwood@gmail.com \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox