From: Mengdong Lin <mengdong.lin@linux.intel.com>
To: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"tiwai@suse.de" <tiwai@suse.de>,
"Lin, Mengdong" <mengdong.lin@intel.com>,
"Koul, Vinod" <vinod.koul@intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@intel.com>
Subject: Re: [PATCH v2 1/2] ASoC: core: Add API to use DMI name in sound card long name
Date: Fri, 6 Jan 2017 14:07:19 +0800 [thread overview]
Message-ID: <586F3417.1010405@linux.intel.com> (raw)
In-Reply-To: <1483566423.2629.17.camel@loki>
On 01/05/2017 05:47 AM, Liam Girdwood wrote:
> On Wed, 2017-01-04 at 15:03 +0800, Mengdong Lin wrote:
>>
>> On 01/04/2017 04:09 AM, Pierre-Louis Bossart wrote:
>> So we'll keep the manufacturer name.
>>
>> And let's put the "Product version" as well if available, Liam?
>
> Yes, lets keep the manufacturer name. I agree with Pierre in that we
> dont want meaningless directories names.
Okay. Thanks for your confirmation!
> Creating a directory structures
> like
>
> 1) manufacturer/product/board OR
> 2) manufacturer/product OR
> 3) manufacturer/board
>
> (2 or 3 if board or product is NULL)
>
> are fine by me and make finding the correct card simpler. You could even
> replace the . with / in your longname to save the string conversion
> later on.
>
> Liam
May we keep the flat directory structure for UCM files?
For the same manufacturer, its DMI vendor name could change, e.g. "Intel
Inc." or "Intel Corporation". In addition, there may be changes caused
by using upper case or low case characters. Since we don't want to
maintain a mapping table and just do verbatim copy of DMI info, it's
hard to group all the products/boards of one manufacturer into one UCM
directory. So I feel it may be better to keep the simple flat directory
structure.
Thanks
Mengdong
next prev parent reply other threads:[~2017-01-06 6:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 4:58 [PATCH v2 0/2] ASoC: Use DMI name in sound card long name mengdong.lin
2017-01-03 4:58 ` [PATCH v2 1/2] ASoC: core: Add API to use " mengdong.lin
2017-01-03 14:40 ` Liam Girdwood
2017-01-03 15:44 ` Lin, Mengdong
2017-01-03 19:28 ` Liam Girdwood
2017-01-03 20:09 ` Pierre-Louis Bossart
2017-01-04 7:03 ` Mengdong Lin
2017-01-04 21:47 ` Liam Girdwood
2017-01-06 6:07 ` Mengdong Lin [this message]
2017-01-09 11:13 ` Liam Girdwood
2017-01-03 5:00 ` [PATCH v2 2/2] ASoC: Intel: Use DMI name for sound card long name in Broadwell machine driver mengdong.lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=586F3417.1010405@linux.intel.com \
--to=mengdong.lin@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mengdong.lin@intel.com \
--cc=pierre-louis.bossart@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).