alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mengdong Lin <mengdong.lin@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
	mengdong.lin@intel.com, liam.r.girdwood@linux.intel.com,
	broonie@kernel.org, pierre-louis.bossart@intel.com
Subject: Re: [PATCH v3 1/2] ASoC: core: Add API to use DMI name in sound card long name
Date: Wed, 11 Jan 2017 14:32:11 +0800	[thread overview]
Message-ID: <5875D16B.8040002@linux.intel.com> (raw)
In-Reply-To: <s5h8tqjmlvc.wl-tiwai@suse.de>


On 01/10/2017 03:09 PM, Takashi Iwai wrote:
> On Tue, 10 Jan 2017 07:42:49 +0100,
> mengdong.lin@linux.intel.com wrote:
>>
>> +/**
>> + * snd_soc_set_dmi_name() - Register DMI names to card
>> + * @card: The card to register DMI names
>> + * @flavour: The flavour "differentiator" for the card amongst its peers.
>> + *
>> + * An Intel machine driver may be used by many different devices but are
>> + * difficult for userspace to differentiate, since machine drivers ususally
>> + * use their own name as the card name (short name) and leave the card long
>> + * name blank. To differentiate such devices and fix bugs due to lack of
>> + * device-specific configurations, this function allows DMI info to be used
>> + * as the sound card long name, in the format of
>> + * "vendor.product.version.board"
>> + * (Character '.' are used to separate different DMI fields here).
>> + * This will help the userspace to load the correct UCM (Use Case Manager)
>> + * configuration.
>> + *
>> + * Possible card long names may be:
>> + * DellInc..XPS139343.01.0310JH
>> + * ASUSTeKCOMPUTERINC..T100TA.1.0.T100TA
>> + * Circuitco.MinnowboardMaxD0PLATFORM.D0.MinnowBoardMAX
>> + * (Please note DMI can also include '.' like"Inc." so you may see double '.
> '
>> + * sometimes)
>
> Looking at the examples above, I wonder whether the dot is the best
> choice as the separator.  Might other letters (e.g. ":" or "=") would
> be clearer?  The colon might be bad if it were combined with the
> alsa-lib plugin syntax, but I guess it won't happen?
>

Hi Takashi,

I found we cannot use ":" as separator. It's because we want to use the 
card long name as the name of the directory to store UCM configuration 
files for this card, and Autoconf cannot support ":" in the directory name.

Both "=" and "-" can work, which would you suggest to use?
I've not observed "-" or "=" in DMI fields till now, and I guess "=" is 
less likely to be used by vendors.

Thanks
Mengdong

  reply	other threads:[~2017-01-11  6:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10  6:42 [PATCH v3 0/2] ASoC: Use DMI name in sound card long name mengdong.lin
2017-01-10  6:42 ` [PATCH v3 1/2] ASoC: core: Add API to use " mengdong.lin
2017-01-10  7:09   ` Takashi Iwai
2017-01-11  6:32     ` Mengdong Lin [this message]
2017-01-11  8:03       ` Takashi Iwai
2017-01-11 10:27         ` Mengdong Lin
2017-01-11 15:01           ` Mark Brown
2017-01-11 15:06             ` Takashi Iwai
2017-01-10  6:43 ` [PATCH v3 2/2] ASoC: Intel: Use DMI name for sound card long name in Broadwell machine driver mengdong.lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5875D16B.8040002@linux.intel.com \
    --to=mengdong.lin@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=mengdong.lin@intel.com \
    --cc=pierre-louis.bossart@intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).