From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AE30C04FFE for ; Mon, 20 May 2024 13:47:22 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 583F4AE8; Mon, 20 May 2024 15:47:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 583F4AE8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1716212840; bh=TlQMwSG+/gBY7QDcpZ58FdFlwzxX6d2C5yctN9arRp4=; h=Date:From:To:In-Reply-To:References:Subject:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=oq0B1uAZfMvCNwxuNcBzmqAAohT0kMKpMCsQo7rVsb6K2yY3U1OpSLjfABRddb/Ga yzFJK9jpsJqiQWFbfjdW1IQpB7ELy5XWyoF850akCQ46gk9sU5ZhgTfQNXPGmyU/HR ShDiI+KLjxL6AccdPDgwjemodD5nRu82GmKhgFrY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 43407F8062D; Mon, 20 May 2024 15:46:24 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 769E7F805E0; Mon, 20 May 2024 15:46:24 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2B5D5F805BE; Mon, 20 May 2024 15:01:36 +0200 (CEST) Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 39779F80588 for ; Mon, 20 May 2024 15:01:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 39779F80588 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=savoirfairelinux.com header.i=@savoirfairelinux.com header.a=rsa-sha256 header.s=DFC430D2-D198-11EC-948E-34200CB392D2 header.b=oG1T2vdH Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 8B8DB9C58EA; Fri, 17 May 2024 05:05:42 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10032) with ESMTP id ycSku0e4je0q; Fri, 17 May 2024 05:05:41 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id E1D8D9C591F; Fri, 17 May 2024 05:05:41 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.savoirfairelinux.com E1D8D9C591F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=savoirfairelinux.com; s=DFC430D2-D198-11EC-948E-34200CB392D2; t=1715936741; bh=cx6CQV5YfxghVjmPjejucL2olCe90bCSbFqa4g71+0M=; h=Date:From:To:Message-ID:MIME-Version; b=oG1T2vdHJ7olkf/IEQ4rw1h56wPiTy9nafFlLPsGCZwsqEJt/hBQwoXKYfPbmqn2h qZu2NlE4sQ8A4gbFeK5DUxGaN4+8TNLmbIKDfM5+i/QQN7IS+ya2Uh+JmKsmsSkqf5 MBGTtuIp7xLTlE+3yW/sFKWA4LY7drC0AoeY8TdAT7jSKPSGqa4jIqgy8pHLsrqkyh yAcrOiTjeSJLLtXbpZhHcSON6ooFo3JQVIidV1+HLSXl00uXRf6t6r0H3XspC0vWKO wEcQ2mrCYmQ0xuC6DEzFord8S+Lfc/I7cQ++SWegOi5kEYBQ0bQ2PDnlLdkJZIuoH9 7VWRve/a3Uxng== X-Virus-Scanned: amavis at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10026) with ESMTP id UkPCSXxrdA7W; Fri, 17 May 2024 05:05:41 -0400 (EDT) Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [192.168.48.237]) by mail.savoirfairelinux.com (Postfix) with ESMTP id ABB829C58EA; Fri, 17 May 2024 05:05:41 -0400 (EDT) Date: Fri, 17 May 2024 05:05:41 -0400 (EDT) From: Elinor Montmasson To: Mark Brown Message-ID: <599489232.349333.1715936741672.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: References: <20240515135411.343333-1-elinor.montmasson@savoirfairelinux.com> <20240515135411.343333-10-elinor.montmasson@savoirfairelinux.com> Subject: Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.8.15_GA_4581 (ZimbraWebClient - GC112 (Linux)/8.8.15_GA_4581) Thread-Topic: ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec Thread-Index: 5nXwooIVrjUMUfEG3TeQl8yJKNJb9Q== Message-ID-Hash: 2FVCOU6SHPDHPYS7AF4THGNEB7R67IFZ X-Message-ID-Hash: 2FVCOU6SHPDHPYS7AF4THGNEB7R67IFZ X-MailFrom: elinor.montmasson@savoirfairelinux.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , shengjiu wang , Xiubo Lee , Fabio Estevam , Nicolin Chen , Takashi Iwai , linux-sound , devicetree , linux-kernel , alsa-devel , linuxppc-dev X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "Mark Brown" Sent: Thursday, 16 May, 2024 14:11:11 > On Wed, May 15, 2024 at 03:54:11PM +0200, Elinor Montmasson wrote: > >> Add documentation about new dts bindings following new support >> for compatible "fsl,imx-audio-generic". > >> audio-codec: >> - $ref: /schemas/types.yaml#/definitions/phandle >> - description: The phandle of an audio codec >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: | >> + The phandle of an audio codec. >> + If using the "fsl,imx-audio-generic" compatible, give instead a pair of >> + phandles with the spdif_transmitter first (driver SPDIF DIT) and the >> + spdif_receiver second (driver SPDIF DIR). >> + items: >> + maxItems: 1 > > This description (and the code) don't feel like they're actually generic > - they're clearly specific to the bidrectional S/PDIF case. I'd expect > something called -generic to cope with single CODECs as well as double, > and not to have any constraints on what those are. I proposed, in an reply of the v3 patch series to Krzysztof Kozlowski, the compatible "fsl,imx-audio-no-codec" instead of "generic". Krzysztof thought it was too generic, but it would convey more clearly that it is for cases without codec driver. Would this other compatible string be more appropriate ? Best regards, Elinor Montmasson