From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E248C433E0 for ; Wed, 3 Jun 2020 17:41:38 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3D522053B for ; Wed, 3 Jun 2020 17:41:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="G8QrOWNM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3D522053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 537D2165F; Wed, 3 Jun 2020 19:40:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 537D2165F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1591206096; bh=h7ngSZlBH1bRjlqNJ79vJDIbHalVaPoQJQ5OmYX6ktY=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=G8QrOWNMi/MmH0i/91aowK/nlEppfuXtfpAcqTe9yVPJ1rVK7DQ9tgaKXUfDqnSAe GNlxBKNlcAhAihpcPMXeVNglkk4Kcr5TsjTrPehXIkBQLMUkLCR6LpvJV4e5DTvcHj brXGDddiKZ85HPPUOPURSz5WeGf7DkkFhZAwmxdc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CEE96F800D0; Wed, 3 Jun 2020 19:40:45 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B2D7FF80212; Wed, 3 Jun 2020 19:40:44 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 15FD0F800D0 for ; Wed, 3 Jun 2020 19:40:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 15FD0F800D0 IronPort-SDR: LRnsg3rps+XdhnWAgOBlThsiO3zaDGg+kXuQga77+eQcc49+TmUSOfFVsgs/ZF1K6sLWAXlVXj /wz24V/rWb6g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2020 10:40:36 -0700 IronPort-SDR: U8Q3jKJJdxY8326H1NSNqGuqc0rqBbP/LzxC/8tfbUjgMbQ9jhbS84uCfyU7OmqtWzg9WezcKD JpSKaOcwHIQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,468,1583222400"; d="scan'208";a="294048219" Received: from unknown (HELO ranjani-desktop) ([10.254.43.45]) by fmsmga004.fm.intel.com with ESMTP; 03 Jun 2020 10:40:35 -0700 Message-ID: <59dcd0873792cd7aff3dfb149f7c09f373f154ec.camel@linux.intel.com> Subject: Re: [PATCH 19/24] ASoC: soc-component: add snd_soc_component_compr_set_metadata() From: Ranjani Sridharan To: Kuninori Morimoto , Mark Brown Date: Wed, 03 Jun 2020 10:40:35 -0700 In-Reply-To: <87imgby3ak.wl-kuninori.morimoto.gx@renesas.com> References: <87a71nzhy2.wl-kuninori.morimoto.gx@renesas.com> <87imgby3ak.wl-kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: Linux-ALSA X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 2020-06-01 at 10:37 +0900, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > component related function should be implemented at > soc-component.c. > This patch adds snd_soc_component_compr_set_metadata(). > > Signed-off-by: Kuninori Morimoto > --- > include/sound/soc-component.h | 2 ++ > sound/soc/soc-component.c | 21 +++++++++++++++++++++ > sound/soc/soc-compress.c | 16 +++------------- > 3 files changed, 26 insertions(+), 13 deletions(-) > > diff --git a/include/sound/soc-component.h b/include/sound/soc- > component.h > index 255014fe6264..ce1df96bb274 100644 > --- a/include/sound/soc-component.h > +++ b/include/sound/soc-component.h > @@ -454,6 +454,8 @@ int snd_soc_component_compr_pointer(struct > snd_compr_stream *cstream, > struct snd_compr_tstamp *tstamp); > int snd_soc_component_compr_copy(struct snd_compr_stream *cstream, > char __user *buf, size_t count); > +int snd_soc_component_compr_set_metadata(struct snd_compr_stream > *cstream, > + struct snd_compr_metadata > *metadata); > > int snd_soc_pcm_component_pointer(struct snd_pcm_substream > *substream); > int snd_soc_pcm_component_ioctl(struct snd_pcm_substream *substream, > diff --git a/sound/soc/soc-component.c b/sound/soc/soc-component.c > index 6a47255767a0..1ac353cf48c5 100644 > --- a/sound/soc/soc-component.c > +++ b/sound/soc/soc-component.c > @@ -591,6 +591,27 @@ int snd_soc_component_compr_copy(struct > snd_compr_stream *cstream, > } > EXPORT_SYMBOL_GPL(snd_soc_component_compr_copy); > > +int snd_soc_component_compr_set_metadata(struct snd_compr_stream > *cstream, > + struct snd_compr_metadata > *metadata) > +{ > + struct snd_soc_pcm_runtime *rtd = cstream->private_data; > + struct snd_soc_component *component; > + int i, ret; > + > + for_each_rtd_components(rtd, i, component) { > + if (component->driver->compress_ops && > + component->driver->compress_ops->set_metadata) { > + ret = component->driver->compress_ops- > >set_metadata( > + component, cstream, metadata); > + if (ret < 0) > + return soc_component_ret(component, > ret); > + } > + } > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(snd_soc_component_compr_set_metadata); > + > int snd_soc_pcm_component_pointer(struct snd_pcm_substream > *substream) > { > struct snd_soc_pcm_runtime *rtd = substream->private_data; > diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c > index 7e05f263b655..62925adb1042 100644 > --- a/sound/soc/soc-compress.c > +++ b/sound/soc/soc-compress.c > @@ -530,26 +530,16 @@ static int soc_compr_set_metadata(struct > snd_compr_stream *cstream, > struct snd_compr_metadata *metadata) > { > struct snd_soc_pcm_runtime *rtd = cstream->private_data; > - struct snd_soc_component *component; > struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0); > - int i, ret; > + int ret; > > ret = snd_soc_dai_compr_set_metadata(cpu_dai, cstream, > metadata); > if (ret < 0) > return ret; > > - for_each_rtd_components(rtd, i, component) { > - if (!component->driver->compress_ops || > - !component->driver->compress_ops->set_metadata) > - continue; > - > - ret = component->driver->compress_ops->set_metadata( > - component, cstream, metadata); > - if (ret < 0) > - return ret; > - } > + ret = snd_soc_component_compr_set_metadata(cstream, metadata); > > - return 0; > + return ret; maybe just, return snd_soc_component_compr_set_metadata(cstream, metadata);? Thanks, Ranjani