From: "Shuming [范書銘]" <shumingf@realtek.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"Flove(HsinFu)" <flove@realtek.com>,
"Oder Chiou" <oder_chiou@realtek.com>,
"Jack Yu" <jack.yu@realtek.com>,
"Derek [方德義]" <derek.fang@realtek.com>
Subject: RE: [PATCH] ASoC: rt1320: Add RT1320 SDCA vendor-specific driver
Date: Fri, 17 May 2024 05:49:29 +0000 [thread overview]
Message-ID: <5a9d28c6e66d495c82546074350ae4ca@realtek.com> (raw)
In-Reply-To: <a062accf-f3f3-46b8-a110-588c4a319909@linux.intel.com>
> >> On GitHub we talked about using the SDCA Initialization table coming
> >> from ACPI, is this still something you're interested in?
> >
> > If the SDCA function is ready, the codec driver could call the API to do the
> blind writes.
>
> The code I have is about ready, it just needs to be cleaned-up and submitted.
>
> But just to be clear, the codec driver would use the API to retrieve an array of
> (address, value) pair. It would be up to the codec driver to do the writes and/or
> patch their regmap.
Understood.
However, the customer requested Realtek to send the primary version to upstream first.
We could modify the codec driver after the patches of the SDCA function are submitted.
> > OK, will add a comment for the version_id.
> > Currently, the blind writes enables the basic function, not the advanced
> mode (speaker protection).
> > However, VER_B has the capability to enable the speaker protection.
> > The codec driver could use the version_id if the customer wants to enable
> the speaker protection.
> > Regarding DSP firmware, the ROM code stores the DSP FW inside the chip.
> > The speaker protection needs other parameters to set.
>
> If there is a speaker protection running on the codec DSP, shouldn't there be a
> source port to pass an echo reference back to the host?
I could create the capture DAI for AEC feedback.
prev parent reply other threads:[~2024-05-20 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 8:59 [PATCH] ASoC: rt1320: Add RT1320 SDCA vendor-specific driver shumingf
2024-05-15 13:23 ` Pierre-Louis Bossart
2024-05-16 3:22 ` Shuming [范書銘]
2024-05-16 14:44 ` Pierre-Louis Bossart
2024-05-17 5:49 ` Shuming [范書銘] [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a9d28c6e66d495c82546074350ae4ca@realtek.com \
--to=shumingf@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox