From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, vkoul@kernel.org
Cc: robh@kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
sanyog.r.kale@intel.com, yung-chuan.liao@linux.intel.com
Subject: Re: [PATCH v4 0/9] soundwire: qcom: various improvements
Date: Fri, 12 Mar 2021 10:33:40 -0600 [thread overview]
Message-ID: <5afd877e-2213-85f5-cd3c-eca8d060d75c@linux.intel.com> (raw)
In-Reply-To: <20210312120009.22386-1-srinivas.kandagatla@linaro.org>
On 3/12/21 6:00 AM, Srinivas Kandagatla wrote:
> Thanks for reviewing v3 of this patchset!
>
> During testing SoundWire controller on SM8250 MTP, we found
> few issues like all the interrupts are not handled,
> all transport parameters are not read from device tree.
> Patch to add Auto Enumeration supported by the controller
> is also part of this series.
>
> Other major issue was register read/writes which was interrupt based
> was an overhead and puts lot of limitation on context it can be used from.
>
> With previous approach number of interrupts generated
> after enumeration are around 130:
> $ cat /proc/interrupts | grep soundwire
> 21: 130 0 0 0 0 0 0 0 GICv3 234 Edge soundwire
>
> after this patch they are just 3 interrupts
> $ cat /proc/interrupts | grep soundwire
> 21: 3 0 0 0 0 0 0 0 GICv3 234 Edge soundwire
>
> So this patchset add various improvements to the existing driver
> to address above issues.
>
> Tested it on SM8250 MTP with 2x WSA881x speakers, HeadPhones on
> WCD938x via lpass-rx-macro and Analog MICs via lpass-tx-macro.
> Also tested on DragonBoard DB845c with 2xWSA881x speakers.
LGTM, for the series
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> Changes since v3:
> - Fixed setting assigned bit during autoenumeration
>
> Srinivas Kandagatla (9):
> dt-bindings: soundwire: qcom: clarify data port bus parameters
> soundwire: qcom: add support to missing transport params
> soundwire: qcom: set continue execution flag for ignored commands
> soundwire: qcom: start the clock during initialization
> soundwire: qcom: update register read/write routine
> soundwire: qcom: add support to new interrupts
> soundwire: export sdw_compare_devid() and sdw_extract_slave_id()
> soundwire: qcom: add auto enumeration support
> soundwire: qcom: wait for enumeration to be complete in probe
>
> .../bindings/soundwire/qcom,sdw.txt | 20 +
> drivers/soundwire/bus.c | 4 +-
> drivers/soundwire/qcom.c | 529 ++++++++++++++----
> include/linux/soundwire/sdw.h | 2 +
> 4 files changed, 442 insertions(+), 113 deletions(-)
>
prev parent reply other threads:[~2021-03-12 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 12:00 [PATCH v4 0/9] soundwire: qcom: various improvements Srinivas Kandagatla
2021-03-12 12:00 ` [PATCH v4 1/9] dt-bindings: soundwire: qcom: clarify data port bus parameters Srinivas Kandagatla
2021-03-23 22:47 ` Rob Herring
2021-03-12 12:00 ` [PATCH v4 2/9] soundwire: qcom: add support to missing transport params Srinivas Kandagatla
2021-03-12 12:00 ` [PATCH v4 3/9] soundwire: qcom: set continue execution flag for ignored commands Srinivas Kandagatla
2021-03-12 12:00 ` [PATCH v4 4/9] soundwire: qcom: start the clock during initialization Srinivas Kandagatla
2021-03-12 12:00 ` [PATCH v4 5/9] soundwire: qcom: update register read/write routine Srinivas Kandagatla
2021-03-12 12:00 ` [PATCH v4 6/9] soundwire: qcom: add support to new interrupts Srinivas Kandagatla
2021-03-12 12:00 ` [PATCH v4 7/9] soundwire: export sdw_compare_devid() and sdw_extract_slave_id() Srinivas Kandagatla
2021-03-12 12:00 ` [PATCH v4 8/9] soundwire: qcom: add auto enumeration support Srinivas Kandagatla
2021-03-20 6:13 ` kernel test robot
2021-03-12 12:00 ` [PATCH v4 9/9] soundwire: qcom: wait for enumeration to be complete in probe Srinivas Kandagatla
2021-03-12 16:33 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5afd877e-2213-85f5-cd3c-eca8d060d75c@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).