From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E4E8C433E0 for ; Fri, 12 Mar 2021 16:58:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C4C76501D for ; Fri, 12 Mar 2021 16:58:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C4C76501D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 906661789; Fri, 12 Mar 2021 17:57:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 906661789 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1615568314; bh=zRrDA4/t8yUidnRL62y6eH5EbaNd3HWQJ/GmDdBjtsY=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Dlu1sRZBclJ6GSItGf5U4sjlv6SO/8G0oQOi3gYN+nFZMrq0W6damgf8mbyObRmTC eG8NcEbpXb7znpH06HPBUDSvaXx7XQKskGdqMlce/9wrjZXm+iwWQMlv/oobWIXrpk gPuXx9G4LMyfMspoRirnLm5TVbILfHzntdrWKmaI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1DE7DF8032B; Fri, 12 Mar 2021 17:56:59 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 50C0EF802E0; Fri, 12 Mar 2021 17:56:55 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E2521F8016C for ; Fri, 12 Mar 2021 17:56:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E2521F8016C IronPort-SDR: xtF919Sfj31VZtvkpWpDZBmrVWG5a0QByQQMlMaACDOvY3a5DoYXiNMF96YiHHxRNekjRA+a9N M30KjTEbWajw== X-IronPort-AV: E=McAfee;i="6000,8403,9921"; a="250223218" X-IronPort-AV: E=Sophos;i="5.81,244,1610438400"; d="scan'208";a="250223218" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 08:56:34 -0800 IronPort-SDR: m7PV7WkfAc93lqSIuY6CTzzWASguNbQtVIwM4ROE95HmqWyBGDjCzP7tQWliwQi4pEojYFkEZk gIQ0aA0uy8ag== X-IronPort-AV: E=Sophos;i="5.81,244,1610438400"; d="scan'208";a="411064612" Received: from akharche-mobl2.ccr.corp.intel.com (HELO [10.212.135.254]) ([10.212.135.254]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 08:56:33 -0800 Subject: Re: [PATCH v4 0/9] soundwire: qcom: various improvements To: Srinivas Kandagatla , vkoul@kernel.org References: <20210312120009.22386-1-srinivas.kandagatla@linaro.org> From: Pierre-Louis Bossart Message-ID: <5afd877e-2213-85f5-cd3c-eca8d060d75c@linux.intel.com> Date: Fri, 12 Mar 2021 10:33:40 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210312120009.22386-1-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: robh@kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com, yung-chuan.liao@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 3/12/21 6:00 AM, Srinivas Kandagatla wrote: > Thanks for reviewing v3 of this patchset! > > During testing SoundWire controller on SM8250 MTP, we found > few issues like all the interrupts are not handled, > all transport parameters are not read from device tree. > Patch to add Auto Enumeration supported by the controller > is also part of this series. > > Other major issue was register read/writes which was interrupt based > was an overhead and puts lot of limitation on context it can be used from. > > With previous approach number of interrupts generated > after enumeration are around 130: > $ cat /proc/interrupts | grep soundwire > 21: 130 0 0 0 0 0 0 0 GICv3 234 Edge soundwire > > after this patch they are just 3 interrupts > $ cat /proc/interrupts | grep soundwire > 21: 3 0 0 0 0 0 0 0 GICv3 234 Edge soundwire > > So this patchset add various improvements to the existing driver > to address above issues. > > Tested it on SM8250 MTP with 2x WSA881x speakers, HeadPhones on > WCD938x via lpass-rx-macro and Analog MICs via lpass-tx-macro. > Also tested on DragonBoard DB845c with 2xWSA881x speakers. LGTM, for the series Reviewed-by: Pierre-Louis Bossart > > Changes since v3: > - Fixed setting assigned bit during autoenumeration > > Srinivas Kandagatla (9): > dt-bindings: soundwire: qcom: clarify data port bus parameters > soundwire: qcom: add support to missing transport params > soundwire: qcom: set continue execution flag for ignored commands > soundwire: qcom: start the clock during initialization > soundwire: qcom: update register read/write routine > soundwire: qcom: add support to new interrupts > soundwire: export sdw_compare_devid() and sdw_extract_slave_id() > soundwire: qcom: add auto enumeration support > soundwire: qcom: wait for enumeration to be complete in probe > > .../bindings/soundwire/qcom,sdw.txt | 20 + > drivers/soundwire/bus.c | 4 +- > drivers/soundwire/qcom.c | 529 ++++++++++++++---- > include/linux/soundwire/sdw.h | 2 + > 4 files changed, 442 insertions(+), 113 deletions(-) >