From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3842CCA9EBC for ; Fri, 25 Oct 2019 16:58:30 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3530B21D81 for ; Fri, 25 Oct 2019 16:58:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="iYS/xC0E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3530B21D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 039C8185F; Fri, 25 Oct 2019 18:57:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 039C8185F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572022707; bh=oRujLfOyEXt/2KVVygCYlAOn2xuGB2Yg+KE4aypto6w=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iYS/xC0En+ZnBSCi2t5BmVhrPXx08fHdJCpcqb1RG3lZaiAJjRSzXx4ljR6qOp4uM ZSLMkvXF9rEdyYVPidSGylBBs2GnOSkM6Xyhj8wHRbzPIGcEysmzpWsV2LZIXVMcMj bcwVs4xRseO+T6+O754M6ywDkRjrQtb+V7sLPTjE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 84F4FF80368; Fri, 25 Oct 2019 18:57:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 122E9F8036F; Fri, 25 Oct 2019 18:57:35 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AB451F802A0 for ; Fri, 25 Oct 2019 18:57:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AB451F802A0 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2019 09:57:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,229,1569308400"; d="scan'208";a="373604667" Received: from davidpat-mobl2.amr.corp.intel.com (HELO [10.251.153.16]) ([10.251.153.16]) by orsmga005.jf.intel.com with ESMTP; 25 Oct 2019 09:57:27 -0700 To: "Lu, Brent" , "alsa-devel@alsa-project.org" References: <1571994691-20199-1-git-send-email-brent.lu@intel.com> <3ce80285-ddb5-653d-cf60-febc9fd0bdee@linux.intel.com> <219281e5-d685-d584-0d22-5dcf3ca2bec2@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <618b3202-6418-a7e2-9b8e-bc32c01d46ed@linux.intel.com> Date: Fri, 25 Oct 2019 11:57:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: "Rojewski, Cezary" , Kuninori Morimoto , Richard Fontana , Jie Yang , "linux-kernel@vger.kernel.org" , Takashi Iwai , Liam Girdwood , Tzung-Bi Shih , Mark Brown , "M, Naveen" , Thomas Gleixner , "Subhransu S . Prusty" Subject: Re: [alsa-devel] [PATCH] ASoC: eve: implement set_bias_level function for rt5514 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 10/25/19 11:14 AM, Lu, Brent wrote: >> >> Can you clarify if the rt5514 needs the MCLK while it's doing the hotword >> detection? > > No, running the detection does not raise the bias level so the set_bias_level > will not be called. The mclk is only turned on then off in mixer control's handler > (rt5514_dsp_voice_wake_up_put) when enabling the hotword detection. > >> >> My point is really that this patch uses a card-level BIAS indication, and I'd like >> to make sure this does not interfere with the audio DSP being in D3 state. > > The function checks the name of dapm so it would only react when rt5514's > bias level is changing. And also the idle_bias_off of the codec driver is true so > it's target_bias_level should not be overwritten in the dapm_power_widgets() > function. The behavior should be similar to the previous patch which is using > supply widget. Ah yes, I did miss this test: + if (!component || strcmp(component->name, RT5514_DEV_NAME)) + return 0; Looks good then, thanks for the explanations. Reviewed-by: Pierre-Louis Bossart _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel