From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Mark Brown" <broonie@kernel.org>
Cc: Miaoqian Lin <linmq006@gmail.com>,
Tzung-Bi Shih <tzungbi@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jiaxin Yu <jiaxin.yu@mediatek.com>,
linux-mediatek@lists.infradead.org,
Akihiko Odaki <akihiko.odaki@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
kernel@collabora.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ASoC: mediatek: mt8183-da7219: Register to module device table
Date: Mon, 7 Nov 2022 10:06:51 +0100 [thread overview]
Message-ID: <63325548-63c6-8405-6481-3b019e7dd656@collabora.com> (raw)
In-Reply-To: <20221104212409.603970-1-nfraprado@collabora.com>
Il 04/11/22 22:24, Nícolas F. R. A. Prado ha scritto:
> Register the compatibles for this module on the module device table so
> it can be automatically loaded when a matching device is found on the
> system.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
Hello Nícolas,
I agree but.... can you please do the same for 8192, 8195, 8186?
Getting them all in one series would make absolute sense... :-)
in the meanwhile, for this one:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>
> sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c b/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
> index 9f22d3939818..0e572fe28c58 100644
> --- a/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
> +++ b/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
> @@ -842,6 +842,7 @@ static const struct of_device_id mt8183_da7219_max98357_dt_match[] = {
> },
> {}
> };
> +MODULE_DEVICE_TABLE(of, mt8183_da7219_max98357_dt_match);
> #endif
>
> static struct platform_driver mt8183_da7219_max98357_driver = {
next prev parent reply other threads:[~2022-11-07 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 21:24 [PATCH 1/2] ASoC: mediatek: mt8183-da7219: Register to module device table Nícolas F. R. A. Prado
2022-11-04 21:24 ` [PATCH 2/2] ASoC: mediatek: mt8183-mt6358: " Nícolas F. R. A. Prado
2022-11-07 9:07 ` AngeloGioacchino Del Regno
2022-11-07 9:06 ` AngeloGioacchino Del Regno [this message]
2022-11-07 14:19 ` [PATCH 1/2] ASoC: mediatek: mt8183-da7219: " Nícolas F. R. A. Prado
2022-11-10 17:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63325548-63c6-8405-6481-3b019e7dd656@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=akihiko.odaki@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jiaxin.yu@mediatek.com \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=tiwai@suse.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox