From mboxrd@z Thu Jan  1 00:00:00 1970
From: gsantosh@codeaurora.org
Subject: Question on compress offload framework memory
	corruption
Date: Wed, 18 Dec 2013 13:17:51 -0000
Message-ID: <63ac7c9c1f4ac8d8ef0ed9587fd1cf5f.squirrel@www.codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.11.231])
 by alsa0.perex.cz (Postfix) with ESMTP id EB28926164C
 for <alsa-devel@alsa-project.org>; Wed, 18 Dec 2013 14:17:52 +0100 (CET)
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: alsa-devel@alsa-project.org
Cc: "Clemens Ladisch   lgirdwood@gmail.com" <clemens@ladisch.de>
List-Id: alsa-devel@alsa-project.org

Hi,

I have following questions in the compressed offload framework API.

static int soc_compr_set_params_fe(struct snd_compr_stream *cstream,
					struct snd_compr_params *params)
{
...
	hw_params = kzalloc(sizeof(*hw_params), GFP_KERNEL);
	if (hw_params == NULL)
		return -ENOMEM;
/*1st question is, what is the use of above allocated memory I do not see
this being used in this function*/

...

	memcpy(&fe->dpcm[fe_substream->stream].hw_params, params,
			sizeof(struct snd_pcm_hw_params));

/* 2nd question is
in above memcpy there is parameter mismatch
&fe->dpcm[fe_substream->stream].hw_params is of structure type struct
snd_pcm_hw_params

params argument is of the structure type struct snd_compr_params
the definition of the two structures are different, how this is working?
this will over right the destination with junk value which will return
in error when this memory is accessed, after memcpy this cpu_dai hw_params
returing with EINVAL error, please explain why this is done this way.
*/

...

}

Regards,
Santosh M G.