From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E65C6C433E0 for ; Tue, 4 Aug 2020 15:37:22 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A9FF207FC for ; Tue, 4 Aug 2020 15:37:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="hCkcXA4l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A9FF207FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DE91D165E; Tue, 4 Aug 2020 17:36:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DE91D165E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1596555441; bh=baQdIACpFgTosn3b8omAUf5wZxdvnmgVQzp1OPoL9Kc=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hCkcXA4lljPv9xmK6LtXvypnNzPoPAOllIloPdRt6ZEh1ARazQEU3VbtpiroALD9C cVIMlwnEsEbf47mfdDWlzET/xvY0gavccOJ1A+kDRnRNBrBlKp3ZwjYaIyuuAbTl19 q46vEfloK+SbwRN+sX3Y3dA6zs8z1Yc4Y88wfYMI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 970E2F8015C; Tue, 4 Aug 2020 17:35:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6A479F8015D; Tue, 4 Aug 2020 17:35:47 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 36E8CF800B7 for ; Tue, 4 Aug 2020 17:35:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 36E8CF800B7 IronPort-SDR: M3rWva0JJBMnPwpjihnQ/n89/He5AyABM78OS429K2q89/9SUDlK1AgDftQu+UJyeRtKuPiF1T XY9iEtcKGGrw== X-IronPort-AV: E=McAfee;i="6000,8403,9703"; a="150127504" X-IronPort-AV: E=Sophos;i="5.75,434,1589266800"; d="scan'208";a="150127504" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2020 08:35:42 -0700 IronPort-SDR: JpDZzfp+0iIkXsi8g7rRgEZzjD9nahjbHNdVjADLj0+eMaV568fu/6U0GZlTecg4lcA9B0BwDU rRZdPfLw5rVg== X-IronPort-AV: E=Sophos;i="5.75,434,1589266800"; d="scan'208";a="288602863" Received: from gggmerek-mobl.amr.corp.intel.com (HELO [10.212.131.193]) ([10.212.131.193]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2020 08:35:40 -0700 Subject: Re: [PATCH v3 2/2] ASoC: Intel: Add period size constraint on strago board To: "Lu, Brent" , Takashi Iwai References: <1596020585-11517-1-git-send-email-brent.lu@intel.com> <1596198365-10105-1-git-send-email-brent.lu@intel.com> <1596198365-10105-3-git-send-email-brent.lu@intel.com> <63bca214-3434-16c6-1b60-adf323aec554@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <6466847a-8aae-24f7-d727-36ba75e95f98@linux.intel.com> Date: Tue, 4 Aug 2020 09:24:49 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Guennadi Liakhovetski , "alsa-devel@alsa-project.org" , Kai Vehmanen , Kuninori Morimoto , "Rojewski, Cezary" , Takashi Iwai , Jie Yang , "linux-kernel@vger.kernel.org" , "yuhsuan@google.com" , Liam Girdwood , Sam McNally , Mark Brown , Ranjani Sridharan , Daniel Stuart , Andy Shevchenko , Yu-Hsuan Hsu , Damian van Soelen X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 8/3/20 11:33 PM, Lu, Brent wrote: >> >> For avoid further misunderstanding: it's fine that CRAS *uses* such a short >> period. It's often required for achieving a short latency. >> >> However, the question is whether the driver can set *only* this value for >> making it working. IOW, if we don't have this constraint, what actually >> happens? If the driver gives the period size alignment, wouldn't CRAS >> choose 240? > > It won't. Without the constraint it becomes 432. Actually CRAS does not set > period size specifically so the value depends on the constraint rules. I don't get this. If the platform driver already stated 240 and 960 samples why would 432 be chosen? Doesn't this mean the constraint is not applied? > [ 52.011146] sound pcmC1D0p: hw_param > [ 52.011152] sound pcmC1D0p: ACCESS 0x1 > [ 52.011155] sound pcmC1D0p: FORMAT 0x4 > [ 52.011158] sound pcmC1D0p: SUBFORMAT 0x1 > [ 52.011161] sound pcmC1D0p: SAMPLE_BITS [16:16] > [ 52.011164] sound pcmC1D0p: FRAME_BITS [32:32] > [ 52.011167] sound pcmC1D0p: CHANNELS [2:2] > [ 52.011170] sound pcmC1D0p: RATE [48000:48000] > [ 52.011173] sound pcmC1D0p: PERIOD_TIME [9000:9000] > [ 52.011176] sound pcmC1D0p: PERIOD_SIZE [432:432] > [ 52.011179] sound pcmC1D0p: PERIOD_BYTES [1728:1728] > [ 52.011182] sound pcmC1D0p: PERIODS [474:474] > [ 52.011185] sound pcmC1D0p: BUFFER_TIME [4266000:4266000] > [ 52.011188] sound pcmC1D0p: BUFFER_SIZE [204768:204768] > [ 52.011191] sound pcmC1D0p: BUFFER_BYTES [819072:819072] > [ 52.011194] sound pcmC1D0p: TICK_TIME [0:0] > > Regards, > Brent > >> >> >> Takashi > >