From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>, alsa-devel@alsa-project.org
Cc: broonie@kernel.org, tiwai@suse.com, lgirdwood@gmail.com
Subject: Re: [PATCH v2] ASoC: Intel: Baytrail: Fix implicit fallthrough warning
Date: Wed, 28 Aug 2019 12:00:14 -0500 [thread overview]
Message-ID: <64773d79-b9ed-f42f-e2b9-4c1c18768348@linux.intel.com> (raw)
In-Reply-To: <20190828095102.15737-1-cezary.rojewski@intel.com>
On 8/28/19 4:51 AM, Cezary Rojewski wrote:
> Append fallthrough statement to fix warning reported during compilation.
>
> Fixes: b80d19c166c4 ("ASoC: Intel: Restore Baytrail ADSP streams only when ADSP was in reset")
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
>
> Changes from v1:
> - made use of fallthrough statement as suggested by Pierre
> - updated commit message
>
> sound/soc/intel/baytrail/sst-baytrail-pcm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/intel/baytrail/sst-baytrail-pcm.c b/sound/soc/intel/baytrail/sst-baytrail-pcm.c
> index 9cbc982d46a9..54f2ee3010ee 100644
> --- a/sound/soc/intel/baytrail/sst-baytrail-pcm.c
> +++ b/sound/soc/intel/baytrail/sst-baytrail-pcm.c
> @@ -193,6 +193,7 @@ static int sst_byt_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
> break;
> case SNDRV_PCM_TRIGGER_SUSPEND:
> pdata->restore_stream = false;
> + /* fallthrough */
> case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
> sst_byt_stream_pause(byt, pcm_data->stream);
> break;
>
next prev parent reply other threads:[~2019-08-28 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 9:51 [PATCH v2] ASoC: Intel: Baytrail: Fix implicit fallthrough warning Cezary Rojewski
2019-08-28 17:00 ` Pierre-Louis Bossart [this message]
2019-08-30 11:45 ` Applied "ASoC: Intel: Baytrail: Fix implicit fallthrough warning" to the asoc tree Mark Brown
2019-08-30 11:45 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64773d79-b9ed-f42f-e2b9-4c1c18768348@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox