From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D310C433EF for ; Mon, 7 Mar 2022 17:07:36 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AE76C1730; Mon, 7 Mar 2022 18:06:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AE76C1730 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646672854; bh=5oomLSrFApsc6z+43W8UIAVGHDuVh8pgP4O3aBa8M74=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WYdnSfpv0oQtL+vH4H37Km4WtreMlr62q/6DgC42UTCuuu+ajQTP2osDX4E5wPIF8 lHqzKIhHi5zj+XNJTd07sb5EJt1F0gg4v4GOAgr9TARejbTSmsQzihqZ12YczMGMWq DgSHiyUE2CpeuLq7VG7gDIz6v3mCMbv84tXl7c8I= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4394AF8013F; Mon, 7 Mar 2022 18:06:44 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 44912F8020D; Mon, 7 Mar 2022 18:06:43 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 693DBF80132 for ; Mon, 7 Mar 2022 18:06:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 693DBF80132 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cZXpveLd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646672801; x=1678208801; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=5oomLSrFApsc6z+43W8UIAVGHDuVh8pgP4O3aBa8M74=; b=cZXpveLd/F3sbV/0tBeAhTNF+b7Adz/tyRDiOes+x5kWIAZLvSmjUKRW WKRUUl1i/wa+MYvd+Am3i8JZ7L+9lcWpojhwMim4siSqUyFhIP5JugCPM IIrEBhckKjjGo7mn1XsKDKANP6NO2+ynEVVP2G1ARloxwWAPkluJMTlOQ 0pIkOwvllEtZEJwS/QwwLAMZnvZAW81GZzYB6zFLUoKDw1jHVFTqNkmYM A1G9+PvNCK4D7+K60DdOhnlTs1Q1wymbtNvXHJ3LWnCb2s2xI9eacLi/o 4hGVKFjbOs3a22B6oIoNgKLH+oXMmEIFAVJxpGsTZXUzdBHfjwZ8aUNK+ A==; X-IronPort-AV: E=McAfee;i="6200,9189,10279"; a="254637998" X-IronPort-AV: E=Sophos;i="5.90,162,1643702400"; d="scan'208";a="254637998" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2022 09:06:35 -0800 X-IronPort-AV: E=Sophos;i="5.90,162,1643702400"; d="scan'208";a="641400160" Received: from zhaojohn-mobl1.amr.corp.intel.com ([10.254.24.100]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2022 09:06:35 -0800 Message-ID: <64f3d41df8e8978af23471ebe05d678f80d3e271.camel@linux.intel.com> Subject: Re: [PATCH v3 10/17] ASoC: Intel: avs: Add basefw runtime-parameter requests From: Ranjani Sridharan To: Cezary Rojewski , alsa-devel@alsa-project.org Date: Mon, 07 Mar 2022 09:06:35 -0800 In-Reply-To: References: <20220304145755.2844173-1-cezary.rojewski@intel.com> <20220304145755.2844173-11-cezary.rojewski@intel.com> <2bc36351e4c14bd4b3d55f26eec2cda1b77e7728.camel@linux.intel.com> <75e4e6e483a90057831fa8b9ab3ece6ef5cc2f12.camel@linux.intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: upstream@semihalf.com, harshapriya.n@intel.com, rad@semihalf.com, tiwai@suse.com, pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com, broonie@kernel.org, amadeuszx.slawinski@linux.intel.com, cujomalainey@chromium.org, lma@semihalf.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 2022-03-07 at 18:02 +0100, Cezary Rojewski wrote: > > What could make it simpler is if you allocate MAX IPC size for > > payload > > in this function and then copy the right size in the > > avs_ipc_get_large_config(). payload_size tells you that information > > anyway right? > > > > > As stated, there is no clear winner here - you had to repeat such > code > > for every getter. > > > > Since we are getting payload_size already, retrieving payload itself > is > > just fine. OK, can you please add a comment to state this in the patch so the reviewer doesnt have to track down where this memory is allocated? Thanks,Ranjani