From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AD89C43334 for ; Mon, 27 Jun 2022 16:00:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3EEFD1698; Mon, 27 Jun 2022 17:59:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3EEFD1698 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1656345629; bh=ENJbuXj656pbEAK4xDMrx8tuaKh/RuP4LbBqC0yn8/s=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DDyTVowHGB21sSEqzSKWRy1uGraHrquG1GczQfn/KW6c7fMNNo3nYY9T1MxkO2zmY 1Z7QopkkOWNnIW+z1/e2hSQHpwl65Pu98fd/FEGnsI2eQeh/ld5GYfclVqcQsFLJeh l/S4j/pWScAivzyLBbUhphBsKyshAhVSAV4lU94w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C5909F80107; Mon, 27 Jun 2022 17:59:38 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4D613F8028B; Mon, 27 Jun 2022 17:59:37 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6EDA8F80107 for ; Mon, 27 Jun 2022 17:59:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6EDA8F80107 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cY1iaIQZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656345573; x=1687881573; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ENJbuXj656pbEAK4xDMrx8tuaKh/RuP4LbBqC0yn8/s=; b=cY1iaIQZtVoiI+5Unj8V3MNjb3FFU8eBoTsJl6tgwPqpZYBXBCWeHXIA 37nKPgOZ9TGwtbg0bw2Vmculme7uZ6R2bo8RnvQdzSoeMmZAEBPYKhUIU a8uc/VEjRaZFYPfg3M+L547wIbqAnzIUuvxn8sZq1FiQri0D1oUdvfVlW Cb3u+UOibkK/D9wC821n/MbEZ4FFyhliOkltQ1XLU2pXNq1mP3wyfrDM7 BDWETfwVAMocblNr+biCZgU0LO+lCR/+l61CswNy/A14uvEjdaSSIAvwB qsGVKENMRkjCq5fOAbtxTeSKIMssYpkRBK7ojQqCEaHLX8yXaLAPfbUJq Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="280238447" X-IronPort-AV: E=Sophos;i="5.92,226,1650956400"; d="scan'208";a="280238447" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 08:59:25 -0700 X-IronPort-AV: E=Sophos;i="5.92,226,1650956400"; d="scan'208";a="622589630" Received: from vthayala-mobl.amr.corp.intel.com (HELO [10.209.144.177]) ([10.209.144.177]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 08:59:24 -0700 Message-ID: <650468f2-4a68-d1fa-157c-827fda5f1ed5@linux.intel.com> Date: Mon, 27 Jun 2022 10:59:23 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.9.1 Subject: Re: [PATCH 0/4] ASoC: Intel: Mark BE DAIs as nonatomic for hsw and Content-Language: en-US To: Cezary Rojewski , alsa-devel@alsa-project.org, broonie@kernel.org References: <20220624134317.3656128-1-cezary.rojewski@intel.com> <3d9b45c0-b415-21d9-6af5-68fa1001ed17@intel.com> <34b54e4e-8997-c2b7-fdf0-24a1b95121ab@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: hdegoede@redhat.com, tiwai@suse.com, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 6/27/22 10:41, Cezary Rojewski wrote: > On 2022-06-27 4:45 PM, Pierre-Louis Bossart wrote: >> On 6/25/22 03:29, Cezary Rojewski wrote: > >>> Hmm.. that's a good feedback. Isn't ASoC's FE<->BE treated as a single >>> PCM substream in sound/core/pcm_native.c though? If so, does it even >>> make sense for card's BE DAI to be atomic, if it's FE counterpart is >>> nonatomic already? Especially if it is specifying platform and cpu_dai >>> that matches Intel's components which we know communicate using IPCs. >> >> I guess it depends on the cpu_dai implementation. Not all >> implementations implement a delay in the .trigger callback and/or rely >> on IPCs. >> >>> Warning is one thing, but will you be also getting rid of the >>> if-statement in soc-pcm.c that actually forces nonatomic=1 on BE when FE >>> is already declared as such? If the if-statement stays, I believe the >>> declaring BE DAIs 'correctly' in the way to go. >> >> I meant just removing the dev_warn() only. >> >> See https://github.com/thesofproject/linux/pull/3723 > > So the framework is still fixing the flag for the driver. Ideally we > would like to have all the drivers assign correct values to ->nonatomic > flag themselves. > > Now when I think about it, the message seems useful - at least as > dev_dbg(). It _guides_ driver developer to the desired approach: setting > the ->nonatomic flag for BE to '1' if the corresponding FE is already > configured as such. that would result in unnecessary changes to all machine drivers to get rid of the message...