From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3526C4167B for ; Tue, 28 Nov 2023 11:59:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A981F9F6; Tue, 28 Nov 2023 12:58:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A981F9F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1701172748; bh=yfxPBjK99C/x7K8jQBPJkHoUui07X/Xl86chAZ47rkc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=N37946wsQ+73VCx6xej68WT6DQnSyzi0xqGPZOy3yUONwWh60wv6CkSaMD+g7xL/g ytbKf3swHqexSvkXdGRuHYZ9D8SHFJhqt2PfuFOa6qOlOlI59N1UOLRVudol6wag37 lqff2OQU4vXkW0H7FrWynso1YwNyguLxEiu5lo5Y= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 99E6FF8057D; Tue, 28 Nov 2023 12:58:36 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 412FFF80587; Tue, 28 Nov 2023 12:58:36 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 76AC7F8016E; Tue, 28 Nov 2023 12:58:30 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BF5CEF80114 for ; Tue, 28 Nov 2023 12:58:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BF5CEF80114 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=PGEXDcdB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701172704; x=1732708704; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=yfxPBjK99C/x7K8jQBPJkHoUui07X/Xl86chAZ47rkc=; b=PGEXDcdB2Bg79MfCs+BJ9cFofrAC49en+67dKWWRNBx5pTEdAldUpfrr DXpo5K5yUXIrnSehPH0/znASfQvhWOAE6uU6Oe33g0yYp0CWHWuc8VJae 2gC/rQtX2w8rC+rtjS8bnrxgbFLTgihl0osNb9WJb66AGGxzf6jg+SbuP uJcsCyFDBL90jneGku7d9ScHDj195pt0cAz1mTbxmkrEe5HS+1roGnzUo i54YtCRtu/vFDxL9Ep96/Pl8XwKhHs1pADaCb0PVhWtYg1dBu97de7CSU Z8iqwu3xgW0VhwvzWDa2osPj5RwCnal9qWRt08nSGZANyQXnh01UNZ+pM A==; X-IronPort-AV: E=McAfee;i="6600,9927,10907"; a="383292374" X-IronPort-AV: E=Sophos;i="6.04,233,1695711600"; d="scan'208";a="383292374" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 03:58:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10907"; a="802941654" X-IronPort-AV: E=Sophos;i="6.04,233,1695711600"; d="scan'208";a="802941654" Received: from anikafix-mobl.ger.corp.intel.com (HELO [10.251.221.103]) ([10.251.221.103]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 03:58:16 -0800 Message-ID: <6710fd66-2a70-4948-aafb-2fcf3d6d2b25@linux.intel.com> Date: Tue, 28 Nov 2023 13:58:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec Content-Language: en-US To: Takashi Iwai Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, pierre-louis.bossart@linux.intel.com, kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com References: <20231127130245.24295-1-peter.ujfalusi@linux.intel.com> <20231127130245.24295-2-peter.ujfalusi@linux.intel.com> <87jzq3pc6r.wl-tiwai@suse.de> <87cyvvp8t6.wl-tiwai@suse.de> <8ede931b-8c9c-4b95-83e5-5f0db9819e8e@linux.intel.com> <878r6jp6jd.wl-tiwai@suse.de> <875y1np5g2.wl-tiwai@suse.de> <87y1eimd23.wl-tiwai@suse.de> <87ttp6mc04.wl-tiwai@suse.de> <96d334c1-9c6b-415b-bfb8-1fab29b1d223@linux.intel.com> <87plzum9w4.wl-tiwai@suse.de> From: =?UTF-8?Q?P=C3=A9ter_Ujfalusi?= In-Reply-To: <87plzum9w4.wl-tiwai@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-ID-Hash: 2JFWSYUUBQWNFAPABFUL4VTDG5NYV7OD X-Message-ID-Hash: 2JFWSYUUBQWNFAPABFUL4VTDG5NYV7OD X-MailFrom: peter.ujfalusi@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 28/11/2023 12:48, Takashi Iwai wrote: >> Well, it is a bit more 'interesting' from that angle. >> for patch two we needed: >> https://lore.kernel.org/linux-sound/20231124124015.15878-1-peter.ujfalusi@linux.intel.com/ > > Ouch, this kind of information has to be mentioned in the patch > description. Otherwise one would take only this series and face a > problem easily. I can imagine such a problem on the stable tree. OK, I will update the commit message >> I would rather not risk to move the hdac_hda as Intel only using address >> 2 as HDMI indication - which I'm still not sure if it is Intel only or >> generic HDA convention. > > Sure, it doesn't sound right, either. > > Can we then add DAPM widgets and routes later conditionally instead of > having it in component driver definition? The issue is with the DAIs. If I remove the dai registering from hdac_hda_dev_probe() to be done in hdac_hda_codec_probe() then the probe will not happen since we do not have the needed components/DAIs to probe the card. If we don't have HDMI then the machine driver will substitute it with dummy-dai, but if we have HDMI then we are not going to probe at all. It is a sort of chicken and egg situation, right? -- Péter