From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Shenghao Ding <13916275206@139.com>,
broonie@kernel.org, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
lgirdwood@gmail.com, perex@perex.cz,
pierre-louis.bossart@linux.intel.com
Cc: kevin-lu@ti.com, shenghao-ding@ti.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
x1077012@ti.com, peeyush@ti.com, navada@ti.com,
gentuser@gmail.com, Ryan_Chu@wistron.com, Sam_Wu@wistron.com
Subject: Re: [PATCH v2 1/5] ASoC: tas2781: Add Header file for tas2781 driver
Date: Mon, 8 May 2023 09:31:18 +0200 [thread overview]
Message-ID: <68205138-a0ae-f6cf-c81b-e94168a01a29@linux.intel.com> (raw)
In-Reply-To: <20230508054453.700-1-13916275206@139.com>
On 5/8/2023 7:44 AM, Shenghao Ding wrote:
> Create Header file for tas2781 driver.
>
> Signed-off-by: Shenghao Ding <13916275206@139.com>
>
> ---
> Changes in v2:
> - fixed issue | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202305022033.LiI7Ojm4-lkp@intel.com/
> Changes to be committed:
> new file: include/sound/tas2781-dsp.h
> new file: include/sound/tas2781-tlv.h
> new file: include/sound/tas2781.h
> ---
...
> +enum channel {
> + top_left_Chn,
> + top_right_chn,
> + bottom_left_Chn,
> + bottom_right_chn,
> + max_chn,
> +};
Why some enums have capitalized Chn? Just use chn everywhere.
prev parent reply other threads:[~2023-05-08 7:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 5:44 [PATCH v2 1/5] ASoC: tas2781: Add Header file for tas2781 driver Shenghao Ding
2023-05-08 7:31 ` Amadeusz Sławiński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68205138-a0ae-f6cf-c81b-e94168a01a29@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=13916275206@139.com \
--cc=Ryan_Chu@wistron.com \
--cc=Sam_Wu@wistron.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gentuser@gmail.com \
--cc=kevin-lu@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=peeyush@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=x1077012@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox