From: David Rhodes <drhodes@opensource.cirrus.com>
To: Lucas Tanure <lucas.tanure@collabora.com>,
David Rhodes <david.rhodes@cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mark Brown <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v6 3/4] ALSA: cs35l41: Add shared boost feature
Date: Wed, 22 Feb 2023 15:56:36 -0600 [thread overview]
Message-ID: <689ffdac-8d52-a76d-8a01-a43b8a7d9fa8@opensource.cirrus.com> (raw)
In-Reply-To: <20230222093244.938156-4-lucas.tanure@collabora.com>
On 2/22/23 03:32, Lucas Tanure wrote:
> +static const struct reg_sequence cs35l41_actv_seq[] = {
> + /* SYNC_BST_CTL_RX_EN = 1; SYNC_BST_CTL_TX_EN = 1 */
> + {CS35L41_MDSYNC_EN, 0x00003000},
> + /* BST_CTL_SEL = MDSYNC */
> + {CS35L41_BSTCVRT_VCTRL2, 0x00000002},
> +};
> +
> +static const struct reg_sequence cs35l41_pass_seq[] = {
> + /* SYNC_BST_CTL_RX_EN = 1; SYNC_BST_CTL_TX_EN = 0 */
> + {CS35L41_MDSYNC_EN, 0x00002000},
> + /* BST_EN = 0 */
> + {CS35L41_PWR_CTRL2, 0x00003300},
> + /* BST_CTL_SEL = MDSYNC */
> + {CS35L41_BSTCVRT_VCTRL2, 0x00000002},
> +};
> +
The passive device only needs to use TX, not RX.
It is transmitting its boost target voltage to the bus so that the
active amp can boost according to the combined target.
Should be:
static const struct reg_sequence cs35l41_pass_seq[] = {
/* SYNC_BST_CTL_RX_EN = 0; SYNC_BST_CTL_TX_EN = 1 */
{CS35L41_MDSYNC_EN, 0x00001000},
...
Thanks,
David
next prev parent reply other threads:[~2023-02-22 21:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 9:32 [PATCH v6 0/4] Add CS35L41 shared boost feature Lucas Tanure
2023-02-22 9:32 ` [PATCH v6 1/4] ASoC: cs35l41: Only disable internal boost Lucas Tanure
2023-02-22 9:32 ` [PATCH v6 2/4] ASoC: cs35l41: Refactor error release code Lucas Tanure
2023-02-22 9:32 ` [PATCH v6 3/4] ALSA: cs35l41: Add shared boost feature Lucas Tanure
2023-02-22 21:56 ` David Rhodes [this message]
2023-02-22 9:32 ` [PATCH v6 4/4] ASoC: dt-bindings: cirrus,cs35l41: Document CS35l41 shared boost Lucas Tanure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=689ffdac-8d52-a76d-8a01-a43b8a7d9fa8@opensource.cirrus.com \
--to=drhodes@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.tanure@collabora.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox