From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD9C4C433E2 for ; Tue, 8 Sep 2020 13:54:14 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3412F23C2E for ; Tue, 8 Sep 2020 13:54:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="jFNBQLbN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3412F23C2E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A22C7173F; Tue, 8 Sep 2020 15:53:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A22C7173F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599573252; bh=+1k1uD5IU66jiOE8+MUpGIyds+igMMxCPRbqDz1L4mA=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jFNBQLbNm4RbAjf455aU5sPxmnTfktnhYbeAr3nQ9QN7IJvd/bAWFPL3vhTq9mbQb yJ+oZui+RUG4TXczs0clH4inxyAufqQ8XlyjfQ7hM5XlQu7/QZAesabaiHucrSyI6M 0h8OJRXM+QgztAghjGhs9JHAg7OLu1QV2KLF0Erk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2D5E5F801F2; Tue, 8 Sep 2020 15:53:22 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 555E8F80264; Tue, 8 Sep 2020 15:53:20 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A8D0AF8015F for ; Tue, 8 Sep 2020 15:53:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A8D0AF8015F IronPort-SDR: vFDR/Yqg+RLPedikZxB1+yoYln1ZmbPCdd59Pv5sjSL1ZIWQBiWT+hGQTeFktQjAOuT7CFqIKb 1bWoT/TvcRvg== X-IronPort-AV: E=McAfee;i="6000,8403,9737"; a="155616534" X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="155616534" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 06:53:09 -0700 IronPort-SDR: 956F71r7a6JZ1C6XielGjK+RnLRhRq38MyfSOcKlJJVVT4ETYmGMjazSwhbmwHtOSf1Aot0c6n MO8OQtJNIYww== X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="448792089" Received: from mgarber-mobl1.amr.corp.intel.com (HELO [10.212.179.134]) ([10.212.179.134]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 06:53:07 -0700 Subject: Re: [PATCH v2 2/4] soundwire: qcom: avoid dependency on CONFIG_SLIMBUS To: Jonathan Marek , linux-arm-msm@vger.kernel.org References: <20200905173905.16541-1-jonathan@marek.ca> <20200905173905.16541-3-jonathan@marek.ca> From: Pierre-Louis Bossart Message-ID: <69955702-c61c-a961-72fd-2f8a6b3ab978@linux.intel.com> Date: Tue, 8 Sep 2020 08:53:06 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200905173905.16541-3-jonathan@marek.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: "moderated list:SOUNDWIRE SUBSYSTEM" , open list , Bjorn Andersson , Vinod Koul , Andy Gross , Sanyog Kale , Bard Liao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 9/5/20 12:39 PM, Jonathan Marek wrote: > The driver may be used without slimbus, so don't depend on slimbus. > > Signed-off-by: Jonathan Marek > --- > drivers/soundwire/Kconfig | 2 +- > drivers/soundwire/qcom.c | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig > index fa2b4ab92ed9..f83d02c9c60a 100644 > --- a/drivers/soundwire/Kconfig > +++ b/drivers/soundwire/Kconfig > @@ -33,7 +33,7 @@ config SOUNDWIRE_INTEL > > config SOUNDWIRE_QCOM > tristate "Qualcomm SoundWire Master driver" > - depends on SLIMBUS > + imply SLIMBUS > depends on SND_SOC > help > SoundWire Qualcomm Master driver. > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index d1e33ef1afac..6401ad451eee 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -753,7 +753,11 @@ static int qcom_swrm_probe(struct platform_device *pdev) > if (!ctrl) > return -ENOMEM; > > +#if IS_ENABLED(CONFIG_SLIBMUS) typo: SLIMBUS. > if (dev->parent->bus == &slimbus_bus) { > +#else > + if (false) { > +#endif > ctrl->reg_read = qcom_swrm_ahb_reg_read; > ctrl->reg_write = qcom_swrm_ahb_reg_write; > ctrl->regmap = dev_get_regmap(dev->parent, NULL); >