From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org
Subject: Re: [PATCH 00/19] ASoC: SOF: improvements for ABI checks and Intel code
Date: Fri, 3 May 2019 09:47:39 -0500 [thread overview]
Message-ID: <6ac56436-5ce1-d977-45ef-f305f77bfe01@linux.intel.com> (raw)
In-Reply-To: <20190503054047.GB14916@sirena.org.uk>
On 5/3/19 12:40 AM, Mark Brown wrote:
> On Tue, Apr 30, 2019 at 06:09:15PM -0500, Pierre-Louis Bossart wrote:
>> This series is a set of relatively small SOF changes after the big
>> batch merged last week (Thanks!). Since we are very close to the merge
>> window and in May where most of the world takes time off, it'd be
>> perfectly understandable if those patches were queued for 5.3, after
>> feedback and corrections as needed.
>
> The headline thing I see when this pops up in my inbox is yet another 20
> patch series for these DSPs, I'm not going to notice the size of the
> patches on a first pass. As I think you've noticed there's a lot of
> reviewer fatigue setting in with this stuff, one thing that'd really
> help here is if there were some help from Intel people with review for
> the DPCM code.
I can certainly understand reviewer fatigue, i've had to put a time
limit on daily reviews to keep my sanity, but I don't get your last
point. These patches were submitted and reviewed by Intel people on
GitHub, what you see here is the result of multiple iterations precisely
to make sure the patches are acceptable for upstream. we've set the goal
of having two Intel aprovers for each patch. Can you elaborate on how we
can make your life simpler?
FYI we are going to have a number of fixes coming in the next 2 months
for HDaudio support, changes to IPC/power flows to support D0ix states
and SoundWire, 3rd party firmware module support, etc, so I really want
to make sure you are comfortable with SOF-related patches, their level
of maturity and the submission rate.
Thanks!
-Pierre
next prev parent reply other threads:[~2019-05-03 14:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 23:09 [PATCH 00/19] ASoC: SOF: improvements for ABI checks and Intel code Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 01/19] ASoC: SOF: add Kconfig option for strict ABI checks Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 02/19] ASOC: SOF: ipc: add support for stricter " Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 03/19] ASoC: SOF: topology: " Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 04/19] ASoC: SOF: Intel: cnl: add pointer ops to use DPIB position Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 05/19] ASoC: SOF: Intel: hda: add the SSP Host Device memory space Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 06/19] ASoC: SOF: Intel: hda: add SSP info to the chip info struct Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 07/19] ASoC: SOF: Intel: hda: set I2S slave before enabling DSP Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 08/19] ASoC: SOF: Intel: hda: set bus->idx as 0 Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 09/19] ASoC: SOF: Intel: hda-pcm: remove useless dependency on hdac_ext Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 10/19] ASoC: SOF: PCM: add period_elapsed work to fix race condition in interrupt context Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 11/19] ASoC: SOF: Intel: use snd_sof_pcm_period_elapsed Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 12/19] ASoC: SOF: ipc: " Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 13/19] ASoC: SOF: Intel: hda-ipc: simplify handling of IPC IRQ Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 14/19] ASoC: SOF: Intel: hda-stream: store stream capabilities Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 15/19] ASoC: SOF: Intel: hda-stream: handle real stream interrupts only Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 16/19] ASoC: SOF: intel: hda: add hw_params_upon_resume flag for hda stream Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 17/19] ASoC: SOF: IPC: add ipc dump function Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 18/19] ASoC: SOF: Intel: APL: " Pierre-Louis Bossart
2019-04-30 23:09 ` [PATCH 19/19] ASoC: SOF: Intel: CNL: " Pierre-Louis Bossart
[not found] ` <20190503054047.GB14916@sirena.org.uk>
2019-05-03 14:47 ` Pierre-Louis Bossart [this message]
[not found] ` <20190506035133.GI14916@sirena.org.uk>
2019-05-06 14:59 ` [PATCH 00/19] ASoC: SOF: improvements for ABI checks and Intel code Pierre-Louis Bossart
2019-05-07 3:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ac56436-5ce1-d977-45ef-f305f77bfe01@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox